Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the roadmap & release strategy after being accepted into scala 2.13.6+ release? #53

Closed
tribbloid opened this issue May 19, 2021 · 10 comments

Comments

@tribbloid
Copy link
Collaborator

tribbloid commented May 19, 2021

(merged since 2.13.6)

https://github.com/scala/scala/releases/tag/v2.13.6

Will this repo be superceded and we move all active development to scala

or this repo remain active and wait for the scala compiler repo to periodically pull from us?

How do we test it for the latest integration?

@tek
Copy link
Owner

tek commented May 19, 2021

good question! I have not worked out any plans yet. But one obvious course of action would be to turn this project into an Analyzer Plugin, since I have added support for that in the compiler, which allows us to provide new features immediately (and old features that were rejected in the compiler PR). Not sure how constrained it will be though

@tek
Copy link
Owner

tek commented May 19, 2021

@tribbloid
Copy link
Collaborator Author

Yeah but obviously if you want to add features this way it will not be backward compatible to earlier scala version. So the question is:

  • is it possible to make it backward compatible? To enable cross-compilation to every versions starting from 2.12.0?

  • (independent of the result of the first question) should the latest change be directly pushed to scala compiler repo, under 'scala.tools.nsc' package? Or @dwijnand will keep pulling from this repo?

The second question should be easier to figure out. I'm also interested in @dwijnand & other committers' preferences

@tek
Copy link
Owner

tek commented May 20, 2021

I think compatibility should be possible. we'll have to give it a try.
about how features are supposed to be pushed, I do not know.

@tribbloid
Copy link
Collaborator Author

I'll just ask on Spark gitter or issue tracker. Hopefully that community won't eat us for breakfast (like what they did to https://ensime.github.io/)

And how could I possibly forgot the most important part?

Congratulations! Long overdue

@dwijnand
Copy link

Scala plugins must be "fully cross-built" meaning they are released against specific Scala versions, such as splain_2.13.5 so a version for 2.13.6+ being architected as an analyzer plugin would be possible, with some specific source repos.

In terms of updating the implementation in the compiler, I don't have the bandwidth to sync them myself, so we would need @tek or another interested party to submit those updates as pull requests.

@tek
Copy link
Owner

tek commented May 20, 2021

thanks @tribbloid 😄

sure @dwijnand , that should be no problem.

@tribbloid
Copy link
Collaborator Author

tribbloid commented May 20, 2021

Thanks a lot @dwijnand

@tek so we keep our package name & repo, that's a good news.

The remaining problem is to facilitate easy pull request into scala compiler (which obviously requires a batch package renaming). I don't know enough about what kind of works are for the first PR, so you should have a better answer

@tek
Copy link
Owner

tek commented May 20, 2021

I'd suggest to start with manual backporting and see how it goes.

@tribbloid
Copy link
Collaborator Author

Should be superseded by 1.0.0 discussion, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants