change the PingAsync logic #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolve if can't connect to clam av server , PingAsync will throw a exception,it should be return false. Signed-off-by: DHclly <335121817@qq.com>
|
Hello and thanks for the contribution, it's really appreciated! There are many users of this package and I've done my best to avoid breaking changes to the existing API. Users could depend on this to throw in some cases, so I think we should keep this method as-is and create a new method called |
because the method PingAsync if not true ,will throw a exception,so add this method only return true/false. Signed-off-by: DHclly <335121817@qq.com>
|
Thank you for your reply , I add the method |
|
Thanks @DHclly I will incorporate this into the next release shortly. |
|
@tekmaven When will this be merged? The exception throwing behavior of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve if can't connect to clam av server ,
PingAsync will throw a exception,it should be return false.
Signed-off-by: DHclly 335121817@qq.com