Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: it turns out we dont really need redis #17

Merged
merged 1 commit into from
Dec 4, 2021

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented Dec 4, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 4, 2021

Codecov Report

Merging #17 (886b3af) into master (d6aa921) will increase coverage by 7.29%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   66.77%   74.07%   +7.29%     
==========================================
  Files          10        9       -1     
  Lines         310      189     -121     
==========================================
- Hits          207      140      -67     
+ Misses         80       35      -45     
+ Partials       23       14       -9     
Impacted Files Coverage Δ
analytics/incr.go 68.18% <ø> (-5.51%) ⬇️
analytics/msg.go 78.57% <66.66%> (+45.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6aa921...886b3af. Read the comment docs.

Copy link
Member

@elianiva elianiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mantap, saya suka nih yg diffnya banyak merahnya

image

@artileda artileda merged commit 481458c into master Dec 4, 2021
@aldy505 aldy505 deleted the refactor/analytics branch December 4, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants