Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: per goland suggestions #21

Merged
merged 3 commits into from
Dec 7, 2021
Merged

refactor: per goland suggestions #21

merged 3 commits into from
Dec 7, 2021

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented Dec 7, 2021

capek bossshh

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #21 (7af25dc) into master (dc73bcf) will decrease coverage by 4.95%.
The diff coverage is 15.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   53.78%   48.83%   -4.96%     
==========================================
  Files          11       11              
  Lines         502      557      +55     
==========================================
+ Hits          270      272       +2     
- Misses        189      235      +46     
- Partials       43       50       +7     
Impacted Files Coverage Δ
analytics/parser.go 100.00% <ø> (ø)
analytics/server/server.go 0.00% <0.00%> (ø)
utils/array.go 100.00% <ø> (ø)
utils/ascii.go 100.00% <ø> (ø)
utils/random.go 100.00% <ø> (ø)
utils/tele.go 100.00% <ø> (ø)
analytics/migration.go 68.13% <11.76%> (-5.68%) ⬇️
analytics/join.go 62.00% <13.33%> (-6.89%) ⬇️
analytics/incr.go 65.71% <20.00%> (-6.17%) ⬇️
analytics/server/repo.go 44.32% <23.07%> (-3.40%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0716a45...7af25dc. Read the comment docs.

Copy link
Contributor

@ronnygunawan ronnygunawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"What doesn't kill you, makes you stronger." - Friedrich Nietzsche

@aldy505 aldy505 merged commit ee6d853 into master Dec 7, 2021
@aldy505 aldy505 deleted the refactor/goland branch December 7, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants