Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add group_id field on analytics #23

Merged
merged 8 commits into from
Dec 9, 2021
Merged

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented Dec 8, 2021

@ronnygunawan requested this

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #23 (cebeed0) into master (3f82375) will increase coverage by 1.66%.
The diff coverage is 72.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   46.93%   48.60%   +1.66%     
==========================================
  Files          13       13              
  Lines         637      679      +42     
==========================================
+ Hits          299      330      +31     
- Misses        280      288       +8     
- Partials       58       61       +3     
Impacted Files Coverage Δ
analytics/server/server.go 0.00% <ø> (ø)
analytics/fetch.go 35.71% <27.27%> (ø)
analytics/migration.go 66.33% <50.00%> (-1.80%) ⬇️
analytics/parser.go 82.35% <80.00%> (-17.65%) ⬇️
analytics/incr.go 66.19% <100.00%> (+0.48%) ⬆️
analytics/join.go 62.74% <100.00%> (+0.74%) ⬆️
analytics/msg.go 81.25% <100.00%> (+2.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f82375...cebeed0. Read the comment docs.

Copy link
Contributor

@ronnygunawan ronnygunawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fr***ing approve!!

analytics/parser.go Outdated Show resolved Hide resolved
analytics/parser.go Outdated Show resolved Hide resolved
Copy link
Member

@elianiva elianiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@elianiva elianiva merged commit 623fe86 into master Dec 9, 2021
@elianiva elianiva deleted the feat/analytics_groupid branch December 9, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants