Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise welcome message #25

Merged
merged 4 commits into from
Feb 14, 2022
Merged

Revise welcome message #25

merged 4 commits into from
Feb 14, 2022

Conversation

RayWP
Copy link
Contributor

@RayWP RayWP commented Feb 5, 2022

As requested by @aldy505, i deleted some messages.
Also for the sake of diversity and Bhinneka Tunggal Ika, i add some languages to the welcome message

@RayWP RayWP requested a review from aldy505 February 5, 2022 23:04
captcha/welcome.go Outdated Show resolved Hide resolved
@aldy505
Copy link
Member

aldy505 commented Feb 6, 2022

@RayWP bisa tolong tambahin lagi ngga messagenya? biar agak banyakan.

sama I noticed a bit of a new line problem on telegram. sekarang kan stringnya pake backtick, tolong ganti jadi normal double quotes aja. kalo ada newline tambahin \n.

contoh:

var something = []string{
  "Hello this is" +
"not creating a new line but\n" +
"this will",
}

@RayWP
Copy link
Contributor Author

RayWP commented Feb 6, 2022

Oke. Brti kayak Java style ya

@aldy505
Copy link
Member

aldy505 commented Feb 6, 2022

it's not Java style, it's C-style

@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #25 (6c2c1c3) into master (c26feb0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   49.27%   49.27%           
=======================================
  Files          14       14           
  Lines         694      694           
=======================================
  Hits          342      342           
  Misses        290      290           
  Partials       62       62           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c26feb0...6c2c1c3. Read the comment docs.

@aldy505 aldy505 merged commit 70731ad into master Feb 14, 2022
@aldy505 aldy505 deleted the reviseWelcomeMessage branch February 14, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants