Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: passing by reference when creating new apps #30

Merged
merged 1 commit into from
Oct 8, 2022

Conversation

YogiPristiawan
Copy link
Contributor

No description provided.

@aldy505
Copy link
Member

aldy505 commented Oct 8, 2022

ga ada pengaruhnya ini ke performance

@YogiPristiawan
Copy link
Contributor Author

ga ada pengaruhnya ini ke performance

yg passing by reference itu ya pak?
hmm saya masih agak bingung sih, aku baca baca katanya biar ga nge-copy large struct

@aldy505
Copy link
Member

aldy505 commented Oct 8, 2022

structnya masih kecil, no problem ini

@YogiPristiawan
Copy link
Contributor Author

structnya masih kecil, no problem ini

oke pakk. mungkin change buat readme sama env.example nya aja ya yg done

@aldy505
Copy link
Member

aldy505 commented Oct 8, 2022

boleh, changes di main.go sama cmd.go rollback aja

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Base: 34.68% // Head: 34.68% // No change to project coverage 👍

Coverage data is based on head (3a2fabd) compared to base (f9cf1ea).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   34.68%   34.68%           
=======================================
  Files          19       19           
  Lines        1254     1254           
=======================================
  Hits          435      435           
  Misses        733      733           
  Partials       86       86           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aldy505 aldy505 merged commit f7c38e4 into teknologi-umum:master Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants