Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reminder): decrement limit properly #53

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented Dec 26, 2023

No description provided.

@aldy505 aldy505 added the bug Something isn't working label Dec 26, 2023
reminder/handler.go Fixed Show fixed Hide fixed
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (3e99120) 38.18% compared to head (25c0447) 38.10%.

Files Patch % Lines
reminder/user_limiter.go 44.11% 13 Missing and 6 partials ⚠️
reminder/handler.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   38.18%   38.10%   -0.09%     
==========================================
  Files          27       27              
  Lines        1875     1916      +41     
==========================================
+ Hits          716      730      +14     
- Misses       1059     1080      +21     
- Partials      100      106       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aldy505 aldy505 merged commit f7ce5b4 into master Dec 26, 2023
4 of 6 checks passed
@aldy505 aldy505 deleted the fix/reminder-decrement-properly branch December 26, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant