Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): filter repositories that has no issue #65

Closed
wants to merge 1 commit into from
Closed

feat(frontend): filter repositories that has no issue #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 11 additions & 9 deletions frontend/src/routes/index.tsx
View file
Open in desktop
Expand Up @@ -90,15 +90,17 @@ export default component$(() => {
})}
</div>
<div class="repository-card-container">
{state.filteredRepositories.map((repo) => (
<RepositoryCard
full_name={mutable(repo.full_name)}
html_url={mutable(repo.html_url)}
description={mutable(repo.description)}
languages={mutable(repo.languages)}
issues={mutable(repo.issues)}
/>
))}
{state.filteredRepositories
.filter(({ issues }) => issues.length > 0)
Copy link
Member

@elianiva elianiva Oct 9, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

benerin filternya bukan disini harusnya, tapi di file ini
https://github.com/teknologi-umum/hacktoberfest/blob/f9eeab86188c75a9ae54ab74229e27c785e97211/frontend/src/services/filter-repositories.ts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ternyata di file itu udah ada filter-nya ya, tapi gak ngefek apa-apa
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

karena dia nunggu ada filter by labels, harusnya filter itu berlaku meskipun gaada labelsnya

.map((repo) => (
<RepositoryCard
full_name={mutable(repo.full_name)}
html_url={mutable(repo.html_url)}
description={mutable(repo.description)}
languages={mutable(repo.languages)}
issues={mutable(repo.issues)}
/>
))}
</div>

<p class="contributor-section-title">Top Contributors</p>
Expand Down