Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish: fix javascript sdk pipeline #109

Merged
merged 1 commit into from
May 15, 2023

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented May 14, 2023

No description provided.

@aldy505 aldy505 requested review from elianiva and RayWP May 14, 2023 05:32
@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b509e5c) 82.08% compared to head (f7ac031) 82.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   82.08%   82.08%           
=======================================
  Files          20       20           
  Lines         709      709           
  Branches       24       24           
=======================================
  Hits          582      582           
  Misses        108      108           
  Partials       19       19           
Flag Coverage Δ
sdk-dotnet 96.39% <ø> (ø)
sdk-go 66.48% <ø> (ø)
sdk-javascript 82.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@RayWP RayWP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elianiva elianiva merged commit 7b9835e into master May 15, 2023
13 checks passed
@elianiva elianiva deleted the publish/javascript-sdk-pipeline branch May 15, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants