setup everything else #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elianiva
approved these changes
Jun 14, 2022
RayWP
approved these changes
Jun 15, 2022
| @@ -9,6 +9,8 @@ public class UserToken { | |||
| private String email; | |||
| @NotNull | |||
| private String token; | |||
| @NotNull | |||
| private Integer limit; | |||
There was a problem hiding this comment.
kalau pakai model gini, berarti nanti request body untuk /approve harus ada attribute "limit"
There was a problem hiding this comment.
yes, emang butuh attribute limit
|
|
||
| RUN native-image --version | ||
|
|
||
| RUN source "$HOME/.sdkman/bin/sdkman-init.sh" && mvn -B clean package -P native --no-transfer-progress |
There was a problem hiding this comment.
kayaknya ini bisa aja langsung mvn -B package
nggak perlu clean, karena package udah include clean
ref: https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#a-build-lifecycle-is-made-up-of-phases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
big changes