Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect Registration with ETCD #36

Merged
merged 3 commits into from
Jul 13, 2022
Merged

connect Registration with ETCD #36

merged 3 commits into from
Jul 13, 2022

Conversation

RayWP
Copy link
Contributor

@RayWP RayWP commented Jul 12, 2022

No description provided.

@RayWP RayWP requested a review from elianiva July 12, 2022 04:27
@RayWP
Copy link
Contributor Author

RayWP commented Jul 12, 2022 •
edited

why removing the environment? turn out, we dont need that, i should have realize that.
why put "http://"+ ?
because in the docker compose the url for db is db:2379, we need the http, so it will become http://db:2379

@RayWP RayWP requested a review from aldy505 July 12, 2022 14:19
@elianiva elianiva merged commit b467e26 into master Jul 13, 2022
@elianiva elianiva deleted the fix-regs branch July 13, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldy505 aldy505 aldy505 approved these changes

@elianiva elianiva elianiva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RayWP @aldy505 @elianiva