Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation #15

Merged
5 commits merged into from
Oct 12, 2021
Merged

Added documentation #15

5 commits merged into from
Oct 12, 2021

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented Oct 10, 2021

closes #5

Let me know if there's something absurd or hard to understand as it's 2 AM now.

@aldy505 aldy505 requested review from a user and elianiva October 10, 2021 19:12
ghost
ghost reviewed Oct 10, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ada error di CI nya, masalahnya disekitar sini ada yang nil read_test.go:85

elianiva
elianiva reviewed Oct 10, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@elianiva elianiva linked an issue Oct 11, 2021 that may be closed by this pull request
Create documentation #5
Closed
@aldy505
Copy link
Member Author

aldy505 commented Oct 11, 2021

Ada error di CI nya, masalahnya disekitar sini ada yang nil read_test.go:85

aku gangerti kenapa CI bisa error. tak cek dulu.

@codecov
Copy link

codecov bot commented Oct 12, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (tests@5ecc5c0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             tests      #15   +/-   ##
========================================
  Coverage         ?   71.02%           
========================================
  Files            ?        6           
  Lines            ?      176           
  Branches         ?        0           
========================================
  Hits             ?      125           
  Misses           ?       35           
  Partials         ?       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ecc5c0...d7210fa. Read the comment docs.

ghost
ghost reviewed Oct 12, 2021
View reviewed changes
platform/migration/migration.go
@@ -14,7 +14,7 @@ func Migrate(conn *sqlx.Conn) error {
`CREATE TABLE IF NOT EXISTS paste (
id VARCHAR(36) PRIMARY KEY NOT NULL,
content MEDIUMTEXT NOT NULL,
created TIMESTAMP NOT NULL,
created TIMESTAMP NOT NULL DEFAULT NOW(),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good move

ghost
ghost approved these changes Oct 12, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goods.

@ghost ghost merged commit 91f1db9 into tests Oct 12, 2021
@aldy505 aldy505 mentioned this pull request Oct 12, 2021
Closed
@aldy505 aldy505 deleted the docs/init branch October 12, 2021 12:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elianiva elianiva elianiva left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create documentation
2 participants
@aldy505 @elianiva