added expense detail page #16
Conversation
marvelalexius
commented
May 26, 2024
marvelalexius
commented
- added a href wrapper in expense card
- installed new badge component from shadcn
- added a href wrapper in expense card - installed new badge component from shadcn
| <h3 className="text-lg font-medium"> | ||
| {new Intl.NumberFormat("id-ID", { | ||
| style: "currency", | ||
| currency: "IDR", |
There was a problem hiding this comment.
The currency won't always be IDR though
There was a problem hiding this comment.
Hmm, what should I use then? Should I use original_currency or do we have an env for deciding which currency to show?
There was a problem hiding this comment.
You should show both original currency and IDR currency though. The original transaction won't always be in IDR, but people who see this site mostly will come from Indonesia. So there's that.
| </h3> | ||
| </div> | ||
| {/* TODO: use whatever we use for detail links. Eg: tx code, unique id, uuid, etc. */} | ||
| <a href={`/expenses/123`}> |
There was a problem hiding this comment.
hmm, kenapa ga langsung pake transaction_code? atau dto nya belum final ya?
There was a problem hiding this comment.
that's the question, masih unclear posisinya, but I think I'll change it to transaction_code langsung
There was a problem hiding this comment.
Yeah I'd also prefer this to be a /expenses/${expense.transaction_code}
| {new Intl.NumberFormat("id-ID", { | ||
| style: "currency", | ||
| currency: "IDR", | ||
| }).format(expense.idr_amount.toNumber())} |
There was a problem hiding this comment.
kenapa ga di buat utility fungsi sendiri ya? jadi kalo misal ada yang perlu disesuaikan tinggal di satu tempat
There was a problem hiding this comment.
You're right, will do it later
