Setup databases extensions in first changelog #248
Conversation
ponceta
added
datamodel
for more information, see https://pre-commit.ci
|
I'm not sure if that should be part of the changelogs, that's more part of the database setup and the requirements. But looking at the dumps, the cenxtensions creations are part of it, so...it sounds ok. |
|
@ponceta I usually also created |
It is needed for the History viewer |
| @@ -1,2 +1,3 @@ | |||
| CREATE EXTENSION IF NOT EXISTS postgis; | |||
| CREATE EXTENSION IF NOT EXISTS hstore; | |||
There was a problem hiding this comment.
The audit is not currently bundled. I would recommend to revisit this before adding this extension. Jon(b) is generally preferred over hstore nowadays.
There was a problem hiding this comment.
dropping hstore requires changes in the history viewer plugin
There was a problem hiding this comment.
Yes, but I am just saying that currently there is nothing in this repo related to the history viewer. It's up to the manager to add this extension, it should not be integrated by default if not use by default.
There was a problem hiding this comment.
it was in qgep and I don't see why we should now suddenly drop it
There was a problem hiding this comment.
#249 I changed the extensions here and added the history viewer needs in a separate PR.
We can always switch to jsonb when we implement it in history viewer.
This is a 1-1 functionnality with QGEP.
There was a problem hiding this comment.
I'm not sure I make myself clear.
I approved the PR before the addition of the hstore extension, added after and merged.
I think it is a good practice to prefer dedicated PRs for each change.
We had former discussions with Arnaud where I think we decided to have this audit functionality apart from the definition of the model. To my opinion, this should be at least optional.
There was a problem hiding this comment.
See #249 for later comments.
Should fix #247