Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history 
pulling in suggested changes.

Co-authored-by: Arnaud J Le Hors <lehors@us.ibm.com>
  • Loading branch information
@chitrangpatel @lehors
chitrangpatel and lehors committed Dec 15, 2023
1 parent 92217e3 commit 9868aa8
Showing 1 changed file with 25 additions and 23 deletions.
48 changes: 25 additions & 23 deletions docs/predicate/slsa/v2.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,19 +68,19 @@ N/A|Resolved reference to `step` and `sidecar container images`.<li>Even if the
{
"name": "config/pipeline",
"uri": "git+https://github.com/octocat/hello-world.git",
"digest": {"sha1": "7fd1a60b01f91b314f59955a4e4d4e80d8edf11d"},
"digest": {"sha1": "7fd1a60b01f91b314f59955a4e4d4e80d8edf11d"}
}, {
"name": "config/pipelineTask",
"uri": "git+https://github.com/octocat/hello-world.git",
"digest": {"sha1": "7fd1a60b01f91b314f59955a4e4d4e80d8edf11d"},
"digest": {"sha1": "7fd1a60b01f91b314f59955a4e4d4e80d8edf11d"}
}, {
"uri": "gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/git-init",
"digest": {
"sha256": "28ff94e63e4058afc3f15b4c11c08cf3b54fa91faa646a4bbac90380cd7158df"},
"sha256": "28ff94e63e4058afc3f15b4c11c08cf3b54fa91faa646a4bbac90380cd7158df"}
}, {
"name": "input/result",
"uri": "git+https://github.com/octocat/hello-world.git",
"digest": {"sha1": "7fd1a60b01f91b314f59955a4e4d4e80d8edf11d"},
"digest": {"sha1": "7fd1a60b01f91b314f59955a4e4d4e80d8edf11d"}
}
]
}
Expand Down Expand Up @@ -130,6 +130,7 @@ This is the case where the top-level build spec (pipeline or task) is fetched fr

```json
{
"_type": "https://in-toto.io/Statement/v0.1",
"predicateType": "https://slsa.dev/provenance/v1",
"subject": [
{
Expand All @@ -146,13 +147,13 @@ This is the case where the top-level build spec (pipeline or task) is fetched fr
"resolver": "git",
"params": [{
"name": "url",
"value": "https://github.com/chuangw6/demos",
"value": "https://github.com/chuangw6/demos"
},{
"name": "revision",
"value": "main",
"value": "main"
},{
"name": "pathInRepo",
"value": "cdf/pipelines/ci-pipeline.yaml",
"value": "cdf/pipelines/ci-pipeline.yaml"
}]
},
"params": [
Expand All @@ -166,11 +167,11 @@ This is the case where the top-level build spec (pipeline or task) is fetched fr
},
{
"name": "DOCKERFILE",
"value": "cdf/src/Dockerfile",
"value": "cdf/src/Dockerfile"
},
{
"name": "kaniko_IMAGE_REF",
"value": "us-central1-docker.pkg.dev/chuangw-test/kaniko-example/ci",
"value": "us-central1-docker.pkg.dev/chuangw-test/kaniko-example/ci"
}
],
"workspaces": [
Expand All @@ -192,8 +193,8 @@ This is the case where the top-level build spec (pipeline or task) is fetched fr
"timeouts": {
"pipeline": "1h",
"tasks": "30m",
"finally": "15m",
},
"finally": "15m"
}
}
},
"internalParameters": {
Expand Down Expand Up @@ -226,7 +227,7 @@ This is the case where the top-level build spec (pipeline or task) is fetched fr
}, {
"uri": "gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/git-init",
"digest": {
"sha256": "28ff94e63e4058afc3f15b4c11c08cf3b54fa91faa646a4bbac90380cd7158df"},
"sha256": "28ff94e63e4058afc3f15b4c11c08cf3b54fa91faa646a4bbac90380cd7158df"}
}, {
"name": "inputs/result",
"uri": "git+https://github.com/octocat/hello-world.git",
Expand All @@ -236,7 +237,7 @@ This is the case where the top-level build spec (pipeline or task) is fetched fr
},
"runDetails": {
"builder": {
"id": "https://uri to your builder",
"id": "https://uri to your builder"
},
"metadata": {
"invocationId": "1aa04ff2-9c2a-47f5-9c75-ed43d259649a",
Expand All @@ -246,7 +247,7 @@ This is the case where the top-level build spec (pipeline or task) is fetched fr
"byProducts": [{
"name": "results",
"content": "eyJuYW1lIjogImZvbyIsInZhbHVlIjogImJhciJ9Cg=="
},
}
]
}
}
Expand All @@ -258,6 +259,7 @@ This is the case where the top-level build spec (pipeline or task) is fetched fr

```json
{
"_type": "https://in-toto.io/Statement/v0.1",
"predicateType": "https://slsa.dev/provenance/v1",
"subject": [
{
Expand All @@ -277,10 +279,10 @@ This is the case where the top-level build spec (pipeline or task) is fetched fr
"value": "https://github.com/chuangw6/demos",
},{
"name": "revision",
"value": "main",
"value": "main"
},{
"name": "pathInRepo",
"value": "cdf/pipelines/ci-task.yaml",
"value": "cdf/pipelines/ci-task.yaml"
}]
},
"params": [
Expand Down Expand Up @@ -310,7 +312,7 @@ This is the case where the top-level build spec (pipeline or task) is fetched fr
],
"serviceAccountName": "myksa",
"timeouts": {
"tasks": "1h",
"tasks": "1h"
},
}
},
Expand Down Expand Up @@ -340,7 +342,7 @@ This is the case where the top-level build spec (pipeline or task) is fetched fr
}, {
"uri": "gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/git-init",
"digest": {
"sha256": "28ff94e63e4058afc3f15b4c11c08cf3b54fa91faa646a4bbac90380cd7158df"},
"sha256": "28ff94e63e4058afc3f15b4c11c08cf3b54fa91faa646a4bbac90380cd7158df"}
}, {
"name": "inputs/result",
"uri": "git+https://github.com/octocat/hello-world.git",
Expand All @@ -360,7 +362,7 @@ This is the case where the top-level build spec (pipeline or task) is fetched fr
"byProducts": [{
"name": "results",
"content": "eyJuYW1lIjogImZvbyIsInZhbHVlIjogImJhciJ9Cg=="
},
}
]
}
}
Expand Down Expand Up @@ -483,7 +485,7 @@ This is the case where the top-level build spec (pipeline or task) is in-lined i
"uri": "distroless.dev/busybox",
"digest": {
"sha256": "186312fcf3f381b5fc1dd80b1afc0d316f3ed39fb4add8ff900d1f0c7c49a92c"
},
}
},
{
"uri": "git+https://my-git-url.git",
Expand All @@ -496,7 +498,7 @@ This is the case where the top-level build spec (pipeline or task) is in-lined i
},
"runDetails": {
"builder": {
"id": "https://uri to your builder",
"id": "https://uri to your builder"
},
"metadata": {
"invocationID": "17e34bd9-e7a2-48b2-8da1-eda6e3552cb5",
Expand Down Expand Up @@ -585,13 +587,13 @@ This is the case where the top-level build spec (pipeline or task) is in-lined i
"uri": "docker.io/library/busybox",
"digest": {
"sha256": "b5d6fe0712636ceb7430189de28819e195e8966372edfc2d9409d79402a0dc16"
},
}
}
]
},
"runDetails": {
"builder": {
"id": "https://uri to your builder",
"id": "https://uri to your builder"
},
"metadata": {
"invocationID": "155a34f8-4ac0-4f00-8d25-0fcd725a25ad",
Expand Down

0 comments on commit 9868aa8

Please sign in to comment.