Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PipelineResource support #734

Closed
wlynch opened this issue Mar 6, 2023 · 8 comments
Closed

Remove PipelineResource support #734

wlynch opened this issue Mar 6, 2023 · 8 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten

Comments

@wlynch
Copy link
Member

wlynch commented Mar 6, 2023

PipelineResources have been deprecated from Pipelines for quite some time now (https://github.com/tektoncd/pipeline/blob/main/docs/deprecations.md#deprecation-table says since Dec 2021) - we should be safe to rip this out from Chains.

@wlynch wlynch added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 6, 2023
@wlynch
Copy link
Member Author

wlynch commented Mar 24, 2023

Heads up - Pipelines was still allowing creation of PipelineResources via v1beta1 through v0.45.0, so it's very likely that there's still usage of Pipeline Resources for recent clients.

Support was removed in v0.46.0, but the API types were removed as well so this breaks our ability to safely watch older Tekton versions if we update our client version to v0.46.0 😭

I reached out on the Pipelines PR to ask to roll back the client changes.

@chuangw6
Copy link
Member

chuangw6 commented Apr 7, 2023

After creating #764 to remove it, I just realized this ticket. Thanks for creating this ticket.

Should we remove support for the pipelineresources in Chains? I feel like if we don't remove it, users who use the combo of pipeline >= v0.46 and chains >= 0.16 will have trouble.

chuangw6 added a commit to chuangw6/chains that referenced this issue Apr 7, 2023
fixes tektoncd#734

 - bump github.com/tektoncd/pipeline to v0.46.0
 - bump k8s.io/client-go to v0.25.7
 - bump k8s.io/code-generator to v0.25.7
 - bump knative.dev/pkg to v0.0.0-20230221145627-8efb3485adcf
 - remove support for PipelineResources in Chains.

Signed-off-by: Chuang Wang <chuangw@google.com>
@lcarva
Copy link
Contributor

lcarva commented Apr 7, 2023

Should we remove support for the pipelineresources in Chains? I feel like if we don't remove it, users who use the combo of pipeline >= v0.46 and chains >= 0.16 will have trouble.

Good question. According to this, the pipeline release v0.44.0 is still supported until Jan 24, 2024. So maybe we should until then?

@wlynch
Copy link
Member Author

wlynch commented Apr 7, 2023

I'd like to keep compatibility with current supported pipeline LTS versions, unless there's a good reason we can't.

We got the resources API change reverted in tektoncd/pipeline#6436 - if/when pipeline releases v0.46.1 we should be able to upgrade with compatibility.

@lcarva lcarva mentioned this issue Apr 11, 2023
6 tasks
@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants