Calculate subjects per formatter #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
tekton-robot
added
the
do-not-merge/work-in-progress
tekton-robot
added
the
size/M
renzodavid9
force-pushed
the
issue-subjects-per-formatter
branch
from
875cbc7
to
47c808b
Compare
tekton-robot
added
size/L
|
/test all |
|
The following is the coverage report on the affected files.
|
tekton-robot
removed
the
do-not-merge/work-in-progress
|
The following is the coverage report on the affected files.
|
chitrangpatel
approved these changes
Jun 7, 2024
|
/un-approve |
tekton-robot
added
the
approved
|
/un-approve |
|
/remove-approve |
tekton-robot
removed
the
approved
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/kind bug |
|
/cherry-pick release-v0.21.x |
1 similar comment
|
/cherry-pick release-v0.21.x |
chitrangpatel
pushed a commit
to chitrangpatel/chains
that referenced
this pull request
Jun 8, 2024
* Calculate subjects per formatter * Tests for new retrieve full uris in grafeas
renzodavid9
added a commit
to renzodavid9/chains
that referenced
this pull request
Jun 9, 2024
* Calculate subjects per formatter * Tests for new retrieve full uris in grafeas (cherry picked from commit 750a98e)
tekton-robot
pushed a commit
that referenced
this pull request
Jun 10, 2024
* Fix field names in generated json statement (#1129) To keep backwards compatibility with previous struct versions (e.g, github.com/in-toto/in-toto-golang/in_toto) we have to use protojson.Marshal function to transform the struct to its json representation so the tags defined in the intoto.Statement are follow and applied to the resulting string. (cherry picked from commit 3bf8cac) * Fix no repeated subjects for v2alpha4 pipelineruns (#1130) Change the pipelinerun v2alpha4 method that calculates the subjects to use `artifact.AppendSubjects` instead of `append` to avoid duplicated subjects. (cherry picked from commit badc734) * Calculate subjects per formatter (#1132) * Calculate subjects per formatter * Tests for new retrieve full uris in grafeas (cherry picked from commit 750a98e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1133
Changes
The way v2alpha3 and v2alpha4 calculate the subjects are different; calling
extract.RetrieveAllArtifactURIsto generate the subjects is wrong if using v2alpha4. This PR add a new method to the payload formatter that returns the subjects according to the logic of each version. It also changes grafeas backend to generate the subject through the payloader and not calling theextract.RetrieveAllArtifactURIsdirectly.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)