Skip to content

Commit

Permalink
Fix vcs links to be static
Browse files Browse the repository at this point in the history
this will fix the pre-commit run

Fixes #2303

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
  • Loading branch information
chmouel committed May 2, 2024
1 parent f3422c7 commit 13f9a39
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 12 deletions.
15 changes: 7 additions & 8 deletions RELEASE_PROCESS.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

- You need to have your own Kubernetes cluster (e.g. `minikube`, `gcp`, or other means) with Tekton installed.

- You need to have [these tools](https://github.com/tektoncd/cli/blob/main/tekton/release.sh#L13y) installed locally.
- You need to have [these tools](https://github.com/tektoncd/cli/blob/31b05eeba893c75a215f3acbe3986e87f4ae94f5/tekton/release.sh#L13y) installed locally.

- You will need to have a [GPG key set up](https://help.github.com/en/github/authenticating-to-github/managing-commit-signature-verification) with your git account to push the release branch.

Expand All @@ -26,7 +26,7 @@ The steps below are meant to be followed in order. Some steps can be done in a d
- Start reading this [README](tekton/README.md), and you can start a new release
with the [release.sh](tekton/release.sh) script.

- When the release is done in https://github.com/tektoncd/cli/releases, edit the
- When the release is done in <https://github.com/tektoncd/cli/releases>, edit the
release and change it from pre-release to released. Make sure to do this before
the next step for the rpm package.

Expand Down Expand Up @@ -55,7 +55,7 @@ dnf upgrade tektoncd-cli

- Make an update on [homebrew-core](https://github.com/Homebrew/homebrew-core/blob/master/Formula/tektoncd-cli.rb) for tektoncd-cli formula.

* Make sure you get the proper `sha256sum`. You need to download the `Source Code (tar.gz)` from this [link](https://github.com/Homebrew/homebrew-core/blob/master/Formula/tektoncd-cli.rb#L4), but replace the version number with the version number you have released. After downloading, run the command below on the downloaded file (once again you will need to replace the version shown below with the released version):
- Make sure you get the proper `sha256sum`. You need to download the `Source Code (tar.gz)` from this [link](https://github.com/Homebrew/homebrew-core/blob/b031f5eb111abdcee3672ca75a8dabefdd57ced2/Formula/t/tektoncd-cli.rb), but replace the version number with the version number you have released. After downloading, run the command below on the downloaded file (once again you will need to replace the version shown below with the released version):

```shell script
sha256sum cli-0.7.1.tar.gz
Expand All @@ -65,16 +65,15 @@ dnf upgrade tektoncd-cli

`72df3075303d2b0393bae9a0f9e9b8441060b8a4db57e613ba8f1bfda03809b5 cli-0.7.1.tar.gz`

* Raise a PR to update like [this](https://github.com/Homebrew/homebrew-core/pull/46492) to Homebrew Core
- Raise a PR to update like [this](https://github.com/Homebrew/homebrew-core/pull/46492) to Homebrew Core

- Make a version update to the test-runner and `tkn` image in the [plumbing](https://github.com/tektoncd/plumbing/) repo. The test-runner image is used to run the CI on the pipeline project, which uses `tkn`. For both Dockerfiles listed below, search for `ARG TKN_VERSION` in the Dockerfile for where to update the release version. Update the version arg to match the version of `tkn` released (i.e. `ARG TKN_VERSION=<RELEASED_VERSION>`).

* [test-runner image](https://github.com/tektoncd/plumbing/blob/main/tekton/images/test-runner/Dockerfile)
- [test-runner image](https://github.com/tektoncd/plumbing/blob/main/tekton/images/test-runner/Dockerfile)

* [tkn image](https://github.com/tektoncd/plumbing/blob/main/tekton/images/tkn/Dockerfile)
- [tkn image](https://github.com/tektoncd/plumbing/blob/main/tekton/images/tkn/Dockerfile)


- Go to https://archlinux.org/packages/community/x86_64/tekton-cli/flag/ and let the packagers know the package is out of date by leaving a message to the release url and your email address so they can update it.
- Go to <https://archlinux.org/packages/community/x86_64/tekton-cli/flag/> and let the packagers know the package is out of date by leaving a message to the release url and your email address so they can update it.

- Update the version numbers in the main [README.md](README.md) to the version you are releasing by opening a pull request to the main branch of this repository. Do not worry about updating the README for the release branch.

Expand Down
8 changes: 4 additions & 4 deletions choco/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ After running the commands above, `tkn` should be installed. You can run `tkn` t

### Uninstall

Run `choco uninstall tektoncd-cli` to uninstall `tkn`.
Run `choco uninstall tektoncd-cli` to uninstall `tkn`.

### Updating the Package to a New Version

To update this package to a newer version of `tkn`, the following updates should be made:

* Edit the version property in [`tektoncd-cli.nuspec`](https://github.com/tektoncd/cli/blob/main/choco/tektoncd-cli.nuspec#L5) to the latest available version of `tkn`.
* Change the [version in the download url for the Windows `tkn` zip](https://github.com/tektoncd/cli/blob/main/choco/tools/chocolateyinstall.ps1#L4) to the latest available version of `tkn`.
* Update the [checksum for the package](https://github.com/tektoncd/cli/blob/main/choco/tools/chocolateyinstall.ps1#L11) by getting the sha256 of the zip file. Example: `Get-FileHash '.\tkn_0.36.0_Windows_x86_64.zip'`. The zip can be downloaded using the release download url from GitHub; just remember to change the version numbers in the url: https://github.com/tektoncd/cli/releases/download/v0.36.0/tkn_0.36.0_Windows_x86_64.zip.
* Edit the version property in [`tektoncd-cli.nuspec`](https://github.com/tektoncd/cli/blob/31b05eeba893c75a215f3acbe3986e87f4ae94f5/choco/tektoncd-cli.nuspec#L5) to the latest available version of `tkn`.
* Change the [version in the download url for the Windows `tkn` zip](https://github.com/tektoncd/cli/blob/31b05eeba893c75a215f3acbe3986e87f4ae94f5/choco/tools/chocolateyinstall.ps1#L4) to the latest available version of `tkn`.
* Update the [checksum for the package](https://github.com/tektoncd/cli/blob/31b05eeba893c75a215f3acbe3986e87f4ae94f5/choco/tools/chocolateyinstall.ps1#L11) by getting the sha256 of the zip file. Example: `Get-FileHash '.\tkn_0.36.0_Windows_x86_64.zip'`. The zip can be downloaded using the release download url from GitHub; just remember to change the version numbers in the url: <https://github.com/tektoncd/cli/releases/download/v0.36.0/tkn_0.36.0_Windows_x86_64.zip>.
* Run `choco pack` in the `choco` directory to build the package
* Run `choco push` to push the built package and make it available for download (NOTE: You will need permissions to push the package/to be authenticated. Reach out to [@danielhelfand](https://github.com/danielhelfand) for more details.)

0 comments on commit 13f9a39

Please sign in to comment.