Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tkn p/t start --showlog uses --prefix=false flag by default #1404

Closed
VeereshAradhya opened this issue Jun 25, 2021 · 0 comments · Fixed by #1405
Closed

tkn p/t start --showlog uses --prefix=false flag by default #1404

VeereshAradhya opened this issue Jun 25, 2021 · 0 comments · Fixed by #1405
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@VeereshAradhya
Copy link
Contributor

Versions and Operating System

  • Kubernetes version:

    Output of kubectl version:

    Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.0", GitCommit:"5797eaecac19b9c0e4d10d3d6b559c074e3c3c88", GitTreeState:"clean", BuildDate:"2021-01-27T07:28:48Z", 
    GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
    Server Version: version.Info{Major:"1", Minor:"21+", GitVersion:"v1.21.0-rc.0+120883f", GitCommit:"120883fe7ff642c7de79ec1e533e4c63cf099eb0", GitTreeState:"clean", BuildDate:"2021-06-12T07:15:42Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"linux/amd64"}
    
    
  • Tekton Pipeline version:

    Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

    $ tkn version
    Client version: 0.19.0
    Pipeline version: v0.22.0
    Triggers version: v0.12.1
    
    
  • Operating System:

    ALL
    

Expected Behavior

tkn p/t start --showlog should not use --prefix=false flag by default

Actual Behavior

tkn p/t start --showlog uses --prefix=false flag by default

Steps to Reproduce the Problem

  1. Create a task/pipeline
  2. Start task/pipeline using the command tkn p/t start <pipeline-name>/<task-name> --showlog

Additional Info

Command execution log

$ tkn p start cli-test-pipeline -L --showlog
PipelineRun started: cli-test-pipeline-run-ks5xg
Waiting for logs to be available...
+ CHECKOUT_DIR=/workspace/output/
+ [[ true == \t\r\u\e ]]
+ cleandir
+ [[ -d /workspace/output/ ]]
+ rm -rf /workspace/output//lost+found
+ rm -rf '/workspace/output//.[!.]*'
+ rm -rf '/workspace/output//..?*'
+ test -z ''
+ test -z ''
+ test -z ''

@VeereshAradhya VeereshAradhya added the kind/bug Categorizes issue or PR as related to a bug. label Jun 25, 2021
pradeepitm12 added a commit to pradeepitm12/cli that referenced this issue Jun 28, 2021
fix tektoncd#1404
this put true as default for --prefix with all the pipeline,
task, and clustertask start command.

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
tekton-robot pushed a commit that referenced this issue Jun 28, 2021
fix #1404
this put true as default for --prefix with all the pipeline,
task, and clustertask start command.

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12 added a commit that referenced this issue Jun 29, 2021
fix #1404
this put true as default for --prefix with all the pipeline,
task, and clustertask start command.

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12 added a commit that referenced this issue Jun 29, 2021
fix #1404
this put true as default for --prefix with all the pipeline,
task, and clustertask start command.

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant