Avoid Use of Previous TaskRunSpecStatus and PipelineRunSpecStatus with Start Commands #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
tekton-robot
added
the
size/L
vdemeester
approved these changes
Oct 13, 2020
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
the
approved
piyush-garg
requested changes
Oct 13, 2020
|
@piyush-garg test for clustertask added |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piyush-garg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
piyush-garg
added a commit
that referenced
this pull request
Oct 21, 2020
#1194 | [Daniel Helfand] update README to v0.13.0 | 2020/09/30-22:18 #1196 | [Chmouel Boudjnah] Update OSX instruction to install from brew 🍻 | 2020/10/02-11:36 #1197 | [Daniel Helfand] reorganize release process docs and add details | 2020/10/07-07:26 #1192 | [Daniel Helfand] add eventlistener logs command | 2020/10/07-08:00 #1198 | [Matt Moore] Bump Knative/K8s dependencies | 2020/10/08-00:34 #1201 | [Daniel Helfand] avoid use of previous TaskRunSpecStatus and PipelineRunSpecStatus | 2020/10/13-17:32 #1205 | [Daniel Helfand] remove assertions to help with debugging eventlistener e2e failures | 2020/10/20-07:27 #1207 | [Piyush Garg] tkn pr describe failing in pr with conditions | 2020/10/20-08:57 #1189 | [Daniel Helfand] refactor pipelinerun and taskrun cancel err based on condition status | 2020/10/20-09:15 #1189 | [Daniel Helfand] add pipelinerun and taskrun cancel e2e tests | 2020/10/20-09:15 null | [Daniel Helfand] common way of referring to tekton resources in user facing messages: EventListener | 2020/10/21-07:21 null | [Daniel Helfand] common way of referring to tekton resources in user facing messages: TriggerBinding | 2020/10/21-08:00 Signed-off-by: Piyush Garg <pgarg@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1200
In #1134, the method for using previous TaskRun/PipelineRun runtime values as part of a new run was changed to capture the entire TaskRunSpec/PipelineRunSpec. The problem with this is that the Spec for TaskRuns/PipelineRuns contain the TaskRunSpecStatus/PipelineRunSpecStatus, which are used for cancelling runs.
If
--use-taskrun/--use-pipelinerunor--lastare passed the name of a cancelled run, the new run will be cancelled. While the choice of having TaskRunSpecStatus/PipelineRunSpecStatus is a bit curious,tknneeds to account for this case. The method used in this pr is to save the SpecStatus and reapply it to the run after the previous spec is copied over to avoid factoring this status into the new run's success or failure.Submitter Checklist
make checkmake generatedRelease Notes
For pull requests with a release note:
/kind bug