Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Hub Dependency #1221

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Updates Hub Dependency #1221

merged 1 commit into from
Oct 28, 2020

Conversation

sm43
Copy link
Member

@sm43 sm43 commented Oct 27, 2020

This updates hub dependency as now API response are changed for
resource APIs tektoncd/hub#123.
Also, fixes hub command docs tektoncd/hub#125

Signed-off-by: Shivam Mukhade smukhade@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

cc @sthaha @piyush-garg @danielhelfand

This updates hub dependency as now API response are changed for
resource APIs tektoncd/hub#123.
Also, fixes hub command docs tektoncd/hub#125

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 27, 2020
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 27, 2020
@sm43
Copy link
Member Author

sm43 commented Oct 27, 2020

/hold
till hub creates 0.4.0 release

@piyush-garg
Copy link
Contributor

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2020
@sthaha
Copy link
Member

sthaha commented Oct 27, 2020

/assign danielhelfand

Copy link
Member

@danielhelfand danielhelfand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2020
@piyush-garg
Copy link
Contributor

/hold cancel

/lgtm

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2020
@tekton-robot tekton-robot merged commit fce859a into tektoncd:master Oct 28, 2020
pradeepitm12 added a commit that referenced this pull request Nov 16, 2020
#1215 | [Piyush Garg] Update readme for 0.13.1 and fix lint task | 2020/10/21-14:41
#1210 | [Daniel Helfand] common way of referring to tekton resources in user facing messages: ClusterTriggerBinding | 2020/10/21-15:55
#1209 | [Daniel Helfand] common way of referring to tekton resources in user facing messages: Condition | 2020/10/21-17:41
#1213 | [Daniel Helfand] common way of referring to tekton resources in user facing messages: TriggerTemplate | 2020/10/21-19:33
#1214 | [shuheiktgw] Fix unit test failures with go 1.15 | 2020/10/22-04:19
#1203 | [Sunil Thaha] Integrate Hub commands into tkn | 2020/10/22-04:41
#1217 | [Daniel Helfand] fix alignment of usage | 2020/10/22-18:47
#1218 | [Daniel Helfand] document NO_COLOR and edit README headers | 2020/10/26-15:40
#1224 | [Daniel Helfand] change --nocolour to --no-color | 2020/10/28-02:57
#1221 | [SM43] Updates Hub Dependency | 2020/10/28-04:51
null | [Daniel Helfand] deprecate -c shorthand for tkn version --check | 2020/11/03-15:37
null | [Pradeep Kumar] Bump pipeline and triggers deps | 2020/11/04-20:12
null | [Daniel Helfand] do not delete clustertask taskruns with --task flag | 2020/11/04-20:59
null | [Piyush Garg] Fix APIversion not shown on describe commands | 2020/11/05-10:54
null | [Pratik Jagrut] Add --all-namespaces flag to tkn triggerbinding list command | 2020/11/06-12:25
null | [Pratik Jagrut] Add --all-namespaces flag to tkn eventlistener list command | 2020/11/06-16:04
null | [vinamra28] Add --all-namespaces flag to TriggerTemplate List subcommand | 2020/11/06-19:39
null | [Chmouel Boudjnah] Make sure we target LTS for ubuntus | 2020/11/06-21:12
null | [Pratik Jagrut] Add --all-namespaces flag to tkn condition list command | 2020/11/09-14:14
null | [Daniel Helfand] remove EventListener log output assertion from e2e tests | 2020/11/11-16:52
null | [Pradeep Kumar] bump pipleine dependency to v0.18.0 | 2020/11/12-11:28
null | [dullest] fix function name typo | 2020/11/12-15:17
null | [Vincent Demeester] Makefile: remove darwin/386 from cross target 🌮 | 2020/11/13-15:58
null | [Pratik Jagrut] Add --no-headers flag to tkn clustertask list command | 2020/11/16-09:50
null | [Pratik Jagrut] Add --no-headers flag to tkn clustertriggerbinding list command | 2020/11/16-10:24

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants