Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pipeline and triggers deps #1225

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Bump pipeline and triggers deps #1225

merged 1 commit into from
Nov 4, 2020

Conversation

pradeepitm12
Copy link
Contributor

@pradeepitm12 pradeepitm12 commented Oct 28, 2020 •
edited

This bumps triggers to 0.9.1
For pipeline its already taken care in
#1198

Signed-off-by: Pradeep Kumar pradkuma@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 28, 2020
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 28, 2020
@pradeepitm12
Copy link
Contributor Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2020
@pradeepitm12
Copy link
Contributor Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2020
@pradeepitm12
Copy link
Contributor Author

/test pull-tekton-cli-integration-tests-0_10

vdemeester
vdemeester approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2020
danielhelfand
danielhelfand reviewed Nov 4, 2020
View reviewed changes
pkg/cmd/eventlistener/describe.go Outdated
Comment on lines 108 to 111
TEMPLATE REF APIVERSION
{{ decorate "bullet" $v.Template.Ref }} {{ $v.Template.APIVersion }}
{{- else }}
TEMPLATE NAME APIVERSION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only thing left might be to match that spacing for TEMPLATE NAME and APIVERSION. It's oddly long, but the spacing should be consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this, but both TEMPLATE NAME APIVERSION and TEMPLATE REF APIVERSION have one tab space.

@pradeepitm12
Copy link
Contributor Author

/retest

danielhelfand
danielhelfand suggested changes Nov 4, 2020
View reviewed changes
Copy link
Member

@danielhelfand danielhelfand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits then I think this is good.

pkg/cmd/eventlistener/describe.go Outdated Show resolved Hide resolved
pkg/cmd/eventlistener/describe.go Outdated Show resolved Hide resolved
pkg/cmd/eventlistener/describe.go
NAME VALUE
{{- range $b := $v.Bindings }}
{{- if ne $b.Name "" }}
{{ decorate "bullet" $b.Name }} {{ $b.Value }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure what to make of this, but the example [here](kubectl apply -f https://raw.githubusercontent.com/tektoncd/triggers/master/examples/eventlisteners/eventlistener-embedded-bindings.yaml) comes back with a <nil> for value:

Name:                      listener-embed-binding
Namespace:                 default
Service Account:           tekton-triggers-example-sa
URL:                       http://el-listener-embed-binding.default.svc.cluster.local:8080
EventListnerServiceName:   el-listener-embed-binding
 
EventListenerTriggers

 NAME
 ∙ foo-trig
 
 BINDINGS

  REF                  KIND   APIVERSION
  ∙ pipeline-binding          
 
  NAME                VALUE
  ∙ message-binding   <nil>
 
  SPEC
  ∙ Params
    message   Hello from the Triggers EventListener(listener-embed-binding)!
 
 TEMPLATE REF          APIVERSION
 ∙ pipeline-template

I suppose we can leave it for now, but might be nice to clean up in future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely, we will need cleanup, as the deprecated part becomes unsupported.

@pradeepitm12
Bump pipeline and triggers deps
269b9bb 
This bumps triggers to 0.9.1
For pipeline its already taken care in
[tektoncd#1198](tektoncd#1198)

Note: takes care of deprecations will need to
clean after deprecations are not support

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
danielhelfand
danielhelfand approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@danielhelfand danielhelfand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielhelfand,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danielhelfand
Copy link
Member

/retest

@tekton-robot tekton-robot merged commit 9dd63cd into tektoncd:master Nov 4, 2020
@danielhelfand danielhelfand mentioned this pull request Nov 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@danielhelfand danielhelfand danielhelfand approved these changes

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@danielhelfand danielhelfand

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pradeepitm12 @tekton-robot @danielhelfand @vdemeester