Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we target LTS for ubuntus #1238

Merged

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Nov 6, 2020

  • Use a base latest for the distribution not rolling,
  • Update README.

Related: tektoncd/website#199

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [ 馃檰馃徑 ] Includes tests (if functionality changed/added)
  • [ 馃檰馃徑 ] Run the code checkers with make check
  • [ 馃檰馃徑 ] Regenerate the manpages, docs and go formatting with make generated
  • [ 馃檰馃徑 ] Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Only latest LTS version of Ubuntu release are supported.

- Use a base latest for the distribution not rolling,
- Update README.

Related: tektoncd/website#199
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 6, 2020
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 6, 2020
@chmouel
Copy link
Member Author

chmouel commented Nov 6, 2020

/retest

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2020
Copy link
Member

@danielhelfand danielhelfand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielhelfand,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 91cb887 into tektoncd:master Nov 6, 2020
@chmouel chmouel deleted the make-sure-we-target-ubuntu-lts branch June 27, 2021 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants