Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-headers flag to tkn triggerbinding list command #1254

Merged

Conversation

pratikjagrut
Copy link
Contributor

Changes

This PR adds support for --no-headers flag to tkn triggerbinding list command as requested in issue #799.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Add support for --no-headers flag to tkn triggerbinding list.

Sample output:
--------------------------------------
tkn triggerbinding list --no-headers
event-binding   23 seconds ago
prod-env        1 week ago
staging-env     23 seconds ago
--------------------------------------
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 17, 2020
@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 17, 2020
@tekton-robot
Copy link
Contributor

Hi @pratikjagrut. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 17, 2020
@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 17, 2020
@pratikjagrut
Copy link
Contributor Author

@vdemeester @pradeepitm12 Can you guys review this PR it's been pending since 6 days now?

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
@chmouel
Copy link
Member

chmouel commented Nov 25, 2020

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2020
@tekton-robot tekton-robot merged commit 73cef19 into tektoncd:master Nov 25, 2020
chmouel added a commit that referenced this pull request Dec 17, 2020
#1260 | [vinamra28] Use goreleaser task from tektoncd/catalog | 2020/11/18-09:01
#1261 | [Pradeep Kumar] update README to v0.14.0 | 2020/11/18-12:25
#1259 | [Pratik Jagrut] Add --no-headers flag to tkn condition list command | 2020/11/25-12:19
#1257 | [Chmouel Boudjnah] Use debian/VERSION when building debian package | 2020/11/25-12:33
#1254 | [Pratik Jagrut] Add --no-headers flag to tkn triggerbinding list command | 2020/11/25-14:13
#1255 | [Pratik Jagrut] Add --no-headers flag to tkn triggertemplate list command | 2020/11/25-14:13
#1258 | [Pratik Jagrut] Add --no-headers flag to tkn eventlistener list command | 2020/11/25-15:11
#1178 | [Vincent Demeester] Basic execution plugin module 📟 | 2020/12/01-12:25
#1242 | [Daniel Helfand] allow --prefix-name and --timeout to be overrode when using --last or --use options | 2020/12/01-12:25
#1250 | [Sunghoon Kang] Ignore --follow flag when TaskRun or PipelineRun is done | 2020/12/02-15:28
null | [SM43] Bumps Hub CLI Dependency | 2020/12/16-12:32
null | [Matt Moore] Hoist an ActivityTimeout option. | 2020/12/16-18:26
null | [Pradeep Kumar] bump pipeline and triggers dep | 2020/12/17-07:47
null | [Daniel Helfand] remove --check shorthand and add global flags to version cmd | 2020/12/17-08:59

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants