Fix --ignore-running not working with -p/-t in delete cmd #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will add the fix to --ignore-running=true is not working with -p/-t/--clustertask in delete cmd resulting in deleting all runs. A bit of refactoring and adds unit tests Fix tektoncd#1571
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XL
vdemeester
approved these changes
Jun 2, 2022
tekton-robot
added
the
approved
|
/retest |
vinamra28
reviewed
Jun 2, 2022
Comment on lines
+264
to
+275
| { | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "tr0-8", | ||
| Namespace: "ns", | ||
| Labels: map[string]string{"tekton.dev/task": "random"}, | ||
| }, | ||
| Spec: v1alpha1.TaskRunSpec{ | ||
| TaskRef: &v1alpha1.TaskRef{ | ||
| Name: "random", | ||
| Kind: v1alpha1.NamespacedTaskKind, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I guess we can avoid adding tests for the v1alpha1 as they anyhow are converted to v1beta1. WDYT?
There was a problem hiding this comment.
for now i added them, but if we want we can create an epic and remove in the whole codebase
Comment on lines
+177
to
+184
| { | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "pipeline-run-4", | ||
| Namespace: "ns", | ||
| CreationTimestamp: metav1.Time{Time: clock.Now()}, | ||
| Labels: map[string]string{"tekton.dev/pipeline": "pipeline"}, | ||
| }, | ||
| Spec: v1alpha1.PipelineRunSpec{ |
vinamra28
reviewed
Jun 3, 2022
Comment on lines
+691
to
+706
| name: "Delete all of task with default --ignore-running", | ||
| command: []string{"delete", "-t", "random", "-f", "-n", "ns", "--ignore-running"}, | ||
| dynamic: seeds[9].dynamicClient, | ||
| input: seeds[9].pipelineClient, | ||
| inputStream: nil, | ||
| wantError: false, | ||
| want: "All TaskRuns(Completed) associated with Task \"random\" deleted in namespace \"ns\"\n", | ||
| }, | ||
| { | ||
| name: "Delete all of task with explicit --ignore-running true", | ||
| command: []string{"delete", "-t", "random", "-f", "-n", "ns", "--ignore-running=true"}, | ||
| dynamic: seeds[10].dynamicClient, | ||
| input: seeds[10].pipelineClient, | ||
| inputStream: nil, | ||
| wantError: false, | ||
| want: "All TaskRuns(Completed) associated with Task \"random\" deleted in namespace \"ns\"\n", |
There was a problem hiding this comment.
seems to be duplicate as the default value of --ignore-running is true.
There was a problem hiding this comment.
Added it to check the default behavior, if somehow the default behavior changes in future
vinamra28
reviewed
Jun 3, 2022
Comment on lines
+718
to
+731
| name: "Delete all of clustertask with default --ignore-running", | ||
| command: []string{"delete", "--clustertask", "random", "-f", "-n", "ns", "--ignore-running"}, | ||
| dynamic: seeds[12].dynamicClient, | ||
| input: seeds[12].pipelineClient, | ||
| inputStream: nil, | ||
| wantError: false, | ||
| want: "All TaskRuns(Completed) associated with ClusterTask \"random\" deleted in namespace \"ns\"\n", | ||
| }, | ||
| { | ||
| name: "Delete all of clustertask with explicit --ignore-running true", | ||
| command: []string{"delete", "--clustertask", "random", "-f", "-n", "ns", "--ignore-running=true"}, | ||
| dynamic: seeds[13].dynamicClient, | ||
| input: seeds[13].pipelineClient, | ||
| inputStream: nil, |
vinamra28
reviewed
Jun 3, 2022
Comment on lines
+1514
to
+1526
| name: "Delete all of task with default --ignore-running", | ||
| command: []string{"delete", "-t", "random", "-f", "-n", "ns", "--ignore-running"}, | ||
| dynamic: seeds[11].dynamicClient, | ||
| input: seeds[11].pipelineClient, | ||
| inputStream: nil, | ||
| wantError: false, | ||
| want: "All TaskRuns(Completed) associated with Task \"random\" deleted in namespace \"ns\"\n", | ||
| }, | ||
| { | ||
| name: "Delete all of task with explicit --ignore-running true", | ||
| command: []string{"delete", "-t", "random", "-f", "-n", "ns", "--ignore-running=true"}, | ||
| dynamic: seeds[12].dynamicClient, | ||
| input: seeds[12].pipelineClient, |
vinamra28
reviewed
Jun 3, 2022
Comment on lines
+1541
to
+1551
| name: "Delete all of clustertask with default --ignore-running", | ||
| command: []string{"delete", "--clustertask", "random", "-f", "-n", "ns", "--ignore-running"}, | ||
| dynamic: seeds[14].dynamicClient, | ||
| input: seeds[14].pipelineClient, | ||
| inputStream: nil, | ||
| wantError: false, | ||
| want: "All TaskRuns(Completed) associated with ClusterTask \"random\" deleted in namespace \"ns\"\n", | ||
| }, | ||
| { | ||
| name: "Delete all of clustertask with explicit --ignore-running true", | ||
| command: []string{"delete", "--clustertask", "random", "-f", "-n", "ns", "--ignore-running=true"}, |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pradeepitm12, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add the fix to --ignore-running=true is not working with
-p/-t/--clustertask in delete cmd resulting in deleting all runs.
A bit of refactoring and adds unit tests
Fix #1571
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes