Bump tektoncd/pipeline to v0.39.0 #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XXL
This will bump tektoncd/pipeline to v0.39.0 and do the necessary changes in code
piyush-garg
force-pushed
the
bump_pipeline_39
branch
from
40873fd
to
a0b4801
Compare
pradeepitm12
approved these changes
Sep 7, 2022
tekton-robot
added
the
approved
|
/test pull-tekton-cli-integration-tests |
vdemeester
reviewed
Sep 7, 2022
| func ParsePodTemplate(httpClient http.Client, podTemplateLocation string, validate file.TypeValidator, errorMsg error) (v1beta1.PodTemplate, error) { | ||
| podTemplate := v1beta1.PodTemplate{} | ||
| func ParsePodTemplate(httpClient http.Client, podTemplateLocation string, validate file.TypeValidator, errorMsg error) (pod.PodTemplate, error) { | ||
| podTemplate := pod.PodTemplate{} |
There was a problem hiding this comment.
Arf.. it should have been pod.Template.. but oh well.
There was a problem hiding this comment.
Oh actually that's the case already, PodTemplate is an alias to Template. Ideally we would use Template there.
There was a problem hiding this comment.
they have both :D
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pradeepitm12, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will bump tektoncd/pipeline to v0.39.0
and do the necessary changes in code
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes