Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolver support in tkn pr log commands #2083

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Jul 21, 2023

Add resolver support for tkn pr logs command

This patch adds all type of resolver support for
pipelinerun logs command

closes: #2016

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

This patch adds all type of resolver support for pipelinerun logs command

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 21, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 21, 2023
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 25, 2023
@pratap0007 pratap0007 changed the title [WIP] Add resolver support in tkn pr log commands Add resolver support in tkn pr log commands Jul 25, 2023
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2023
@piyush-garg
Copy link
Contributor

@pratap0007 This seems very important feature to have e2e tests, at least for one resolver kind. Can you please add that?

This patch adds all type of resolver support for
pipelinerun logs command

closes: tektoncd#2016

Signed-off-by: Shiv Verma <shverma@redhat.com>
@pratap0007
Copy link
Contributor Author

/test pull-tekton-cli-integration-tests

@piyush-garg
Copy link
Contributor

/retest

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@piyush-garg
Copy link
Contributor

/test easycla

@tekton-robot
Copy link
Contributor

@piyush-garg: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-cli-build-cross-tests
  • /test pull-tekton-cli-build-tests
  • /test pull-tekton-cli-integration-tests
  • /test pull-tekton-cli-unit-tests

Use /test all to run all jobs.

In response to this:

/test easycla

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot merged commit 3aa2c44 into tektoncd:main Aug 1, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tkn pr logs has problems if resolver was involved in the pipelinerun
4 participants