starts pipeline with new resource #371

pradeepitm12 · 2019-10-21T13:22:52Z

this provides user with comfort to start pipeline with two
options

use existing resource in the namespace or
create new resource on the go while starting the pipeline

Signed-off-by: Pradeep Kumar pradkuma@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Regenerate the manpages and docs with make docs and make man if needed.
Run the code checkers with make check
Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

release-note

tekton-robot · 2019-10-21T13:25:12Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	89.7%	86.7%	-3.0

tekton-robot · 2019-10-21T14:28:32Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	89.7%	86.7%	-3.0

tekton-robot · 2019-10-21T14:42:47Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	89.7%	86.7%	-3.0
pkg/cmd/version/version.go	73.6%	70.9%	-2.7

pradeepitm12 · 2019-10-21T15:03:25Z

/retest

tekton-robot · 2019-10-22T06:36:43Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	89.7%	86.7%	-3.0
pkg/cmd/pipelineresource/create.go	58.2%	76.5%	18.3

piyush-garg · 2019-10-22T06:55:44Z

/test pull-tekton-cli-build-cross-tests

piyush-garg · 2019-10-22T06:56:01Z

/test pull-tekton-cli-build-tests

tekton-robot · 2019-10-22T07:30:46Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	89.7%	86.7%	-3.0

tekton-robot · 2019-10-22T08:49:30Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	89.7%	86.7%	-3.0

tekton-robot · 2019-10-22T09:03:12Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	89.7%	86.7%	-3.0
pkg/cmd/pipelineresource/create.go	58.2%	76.5%	18.3

pradeepitm12 · 2019-10-22T09:43:34Z

/test pull-tekton-cli-build-cross-tests

tekton-robot · 2019-10-22T10:47:29Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	89.7%	86.7%	-3.0

pradeepitm12 · 2019-10-22T10:51:49Z

/test pull-tekton-cli-unit-tests

pradeepitm12 · 2019-10-22T11:16:12Z

/test pull-tekton-cli-unit-tests

vdemeester · 2019-10-23T12:15:18Z

pkg/cmd/pipeline/start.go

+			opt.Resources = append(opt.Resources, res.Name+"="+newres.Name)
+			return nil
+		}
+		// first ask if user wants to create new resource or use existing one


Should we do that (ask the question first), or should we had an "create a resource" option in the list ? (the later seems tricker to achieve though 😓)

@vdemeester
@sthaha also suggests the same thing.
It was not that tricky as we thought of, I have updated the PR addressing the same.

tekton-robot · 2019-10-24T15:35:10Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	88.7%	86.8%	-1.9

tekton-robot · 2019-10-24T15:49:43Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	88.7%	86.8%	-1.9

pradeepitm12 · 2019-10-24T16:30:35Z

/test pull-tekton-cli-build-tests

tekton-robot · 2019-10-24T16:49:18Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	88.7%	86.8%	-1.9

tekton-robot · 2019-10-25T11:25:14Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	88.7%	86.8%	-1.9

tekton-robot · 2019-10-26T04:27:04Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	88.7%	86.8%	-1.9

hrishin · 2019-10-30T04:41:59Z

@pradeepitm12 build job is failing. Shall we fix that?

tekton-robot · 2019-10-30T05:40:20Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	88.8%	86.9%	-1.9

tekton-robot · 2019-10-30T05:53:34Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	88.8%	86.9%	-1.9

tekton-robot · 2019-10-30T06:25:18Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	88.8%	86.9%	-1.9

tekton-robot · 2019-10-30T06:45:59Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	88.8%	86.9%	-1.9

tekton-robot · 2019-10-31T06:57:22Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	88.8%	86.9%	-1.9

tekton-robot · 2019-10-31T07:35:38Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	88.8%	86.9%	-1.9

tekton-robot · 2019-11-06T06:13:53Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	88.8%	86.9%	-1.9

tekton-robot · 2019-11-06T06:41:37Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	88.8%	86.9%	-1.9

tekton-robot · 2019-11-06T07:58:38Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	88.8%	86.9%	-1.9

start pipeline shows the list of resources available in the namespace, also adds an option in the last to create new resource on the go start pipeline directly jumps to create resource flow if there are no resource found in the namespace Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>

tekton-robot · 2019-11-06T08:23:55Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	88.8%	86.9%	-1.9

vdemeester

/lgtm

tekton-robot · 2019-11-06T08:52:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vdemeester · 2019-11-06T10:49:48Z

/test pull-tekton-cli-unit-tests

pradeepitm12 · 2019-11-06T11:05:00Z

/test pull-tekton-cli-unit-tests

tekton-robot requested review from chmouel and vdemeester October 21, 2019 13:22

googlebot added the cla: yes label Oct 21, 2019

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 21, 2019

vdemeester reviewed Oct 23, 2019

View reviewed changes

vdemeester added this to the 0.5.0 🐱 milestone Oct 23, 2019

vdemeester approved these changes Nov 6, 2019

View reviewed changes

tekton-robot assigned vdemeester Nov 6, 2019

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2019

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2019

tekton-robot merged commit ecd3cd5 into tektoncd:master Nov 6, 2019

starts pipeline with new resource #371

starts pipeline with new resource #371

Conversation

pradeepitm12 commented Oct 21, 2019 • edited

Changes

Submitter Checklist

Release Notes

tekton-robot commented Oct 21, 2019

tekton-robot commented Oct 21, 2019

tekton-robot commented Oct 21, 2019

pradeepitm12 commented Oct 21, 2019

tekton-robot commented Oct 22, 2019

piyush-garg commented Oct 22, 2019

piyush-garg commented Oct 22, 2019

tekton-robot commented Oct 22, 2019

tekton-robot commented Oct 22, 2019

tekton-robot commented Oct 22, 2019

pradeepitm12 commented Oct 22, 2019

tekton-robot commented Oct 22, 2019

pradeepitm12 commented Oct 22, 2019

pradeepitm12 commented Oct 22, 2019

vdemeester Oct 23, 2019

Choose a reason for hiding this comment

pradeepitm12 Oct 24, 2019

Choose a reason for hiding this comment

tekton-robot commented Oct 24, 2019

tekton-robot commented Oct 24, 2019

pradeepitm12 commented Oct 24, 2019

tekton-robot commented Oct 24, 2019

tekton-robot commented Oct 25, 2019

tekton-robot commented Oct 26, 2019

hrishin commented Oct 30, 2019

tekton-robot commented Oct 30, 2019

tekton-robot commented Oct 30, 2019

tekton-robot commented Oct 30, 2019

tekton-robot commented Oct 30, 2019

tekton-robot commented Oct 31, 2019

tekton-robot commented Oct 31, 2019

tekton-robot commented Nov 6, 2019

tekton-robot commented Nov 6, 2019

tekton-robot commented Nov 6, 2019

tekton-robot commented Nov 6, 2019

vdemeester left a comment

Choose a reason for hiding this comment

tekton-robot commented Nov 6, 2019

vdemeester commented Nov 6, 2019

pradeepitm12 commented Nov 6, 2019

pradeepitm12 commented Oct 21, 2019 •

edited