Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile fixes #687

Merged
merged 2 commits into from
Feb 11, 2020
Merged

Makefile fixes #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a274ce
Makefile fixes
chmouel Feb 6, 2020
bc7c4b9
Update github pull request templates
chmouel Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/pull_request_template.md
View file
Open in desktop
Expand Up @@ -11,9 +11,8 @@ These are the criteria that every PR should meet, please check them off as you
review them:

- [ ] Includes [tests](https://github.com/tektoncd/community/blob/master/standards.md#principles) (if functionality changed/added)
- [ ] Includes [docs](https://github.com/tektoncd/community/blob/master/standards.md#principles) (if user facing)
- [ ] Regenerate the manpages and docs with `make docs` and `make man` if needed.
- [ ] Run the code checkers with `make check`
- [ ] Regenerate the manpages, docs and go formatting with `make generated`
- [ ] Commit messages follow [commit message best practices](https://github.com/tektoncd/community/blob/master/standards.md#commit-messages)

_See [the contribution guide](https://github.com/tektoncd/cli/blob/master/CONTRIBUTING.md)
Expand Down
9 changes: 6 additions & 3 deletions Makefile
View file
Open in desktop
Expand Up @@ -47,7 +47,7 @@ check: lint test
test: test-unit ## run all tests

.PHONY: lint
lint: ## run linter(s)
lint: lint-yaml ## run linter(s)
@echo "Linting..."
@golangci-lint run ./... --timeout 5m

Expand Down Expand Up @@ -80,13 +80,16 @@ man: bin/docs ## update manpages
@echo "Update generated manpages"
@./bin/docs --target=./docs/man/man1 --kind=man

.PHONY: generated
generated: test-unit-update-golden man docs fmt ## generate all files that needs to be generated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little bit worried to put test-unit-update-golden in generated as this might update golden file when not intended by the user (and thus hide a unwanted change in the output)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would it be? this should not happen isnt it ? I mean the point is to have the same exact output unless a code change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vdemeester ping!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, not sure 😛


.PHONY: clean
clean: ## clean build artifacts
rm -fR bin VERSION

.PHONY: fmt ## formats teh god code(excludes vendors dir)
.PHONY: fmt ## formats the GO code(excludes vendors dir)
fmt:
@go fmt $(go list ./... | grep -v /vendor/)
@go fmt `go list ./... | grep -v /vendor/`

.PHONY: help
help: ## print this help
Expand Down