Provides --last option of the describe of PipelineRun/TaskRun to describe the most recent PipelineRun/TaskRun

[anshulvermapatel]

$Title

Fixes #871

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Run the code checkers with make check
• Regenerate the manpages, docs and go formatting with make generated
• Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

release-note

[tekton-robot]

Hi @anshulvermapatel. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[danielhelfand]

/ok-to-test

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipelinerun/describe.go	51.2%	56.0%	4.8
pkg/cmd/taskrun/describe.go	51.2%	56.0%	4.8

[danielhelfand]

To include all the test data, wouldn't you want the second PipelineRun as well? Not familiar with using the dynamic client with tests. /cc @pradeepitm12

[anshulvermapatel]

Yaa, I think I should add pipelineRuns[1] as well, my bad.

[pradeepitm12]

Yes, resources should be added in the dynamic client, but it is not necessary to do add all, the resources which are accessed(get, list, watch, delete, etc) with the help of the dynamic client will give return nil if the resource is not added in the test-dynamic client.
Hope this helps, for any other thing please do let me know.

[anshulvermapatel]

Done, already added.

[danielhelfand]

Build test failure is from go-critic. Wants you to rewrite if/else if/else as switch:

pkg/cmd/pipelinerun/describe.go:81:4: ifElseChain: rewrite if-else to switch statement (gocritic)
			if len(args) == 0 && !opts.Last {
			^
pkg/cmd/taskrun/describe.go:80:4: ifElseChain: rewrite if-else to switch statement (gocritic)
			if len(args) == 0 && !opts.Last {

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipelinerun/describe.go	51.2%	56.0%	4.8
pkg/cmd/taskrun/describe.go	51.2%	56.0%	4.8

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipelinerun/describe.go	51.2%	56.0%	4.8
pkg/cmd/taskrun/describe.go	51.2%	56.0%	4.8

[danielhelfand]

Just two last nits, and I think this should be good:

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipelinerun/describe.go	51.2%	56.0%	4.8
pkg/cmd/taskrun/describe.go	51.2%	56.0%	4.8

[danielhelfand]

/test pull-tekton-cli-integration-tests

[danielhelfand]

/test pull-tekton-cli-integration-tests

[danielhelfand]

/lgtm

[pradeepitm12]

@anshulvermapatel it would be really nice if you could mark all the comments as resolved. Then we can move forward with it.

[anshulvermapatel]

@anshulvermapatel it would be really nice if you could mark all the comments as resolved. Then we can move forward with it.

@pradeepitm12 , Marked them resolved.

[pradeepitm12]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [danielhelfand]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment