Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to provide error in case of no pr logs #989

Merged
merged 1 commit into from
May 26, 2020
Merged

Fix to provide error in case of no pr logs #989

merged 1 commit into from
May 26, 2020

Conversation

vinamra28
Copy link
Member

Changes

Earlier when we do tkn pr logs <pr-name> we get no logs found even if logs are available which is fixed in this PR

Fixes: #969

Signed-off-by: vinamra28 vinjain@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

release-note

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 21, 2020
@tekton-robot
Copy link
Contributor

Hi @vinamra28. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 21, 2020
@piyush-garg
Copy link
Contributor

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 21, 2020
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 21, 2020
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 21, 2020
danielhelfand
danielhelfand suggested changes May 21, 2020
View reviewed changes
pkg/log/pipeline_reader.go Outdated Show resolved Hide resolved
pkg/log/pipeline_reader.go Outdated Show resolved Hide resolved
pkg/log/pipeline_reader.go Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 22, 2020
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2020
@danielhelfand danielhelfand added this to the 0.10.0 🐅 milestone May 26, 2020
@vinamra28
Fix to provide error in case of no pr logs
b15de51 
Signed-off-by: vinamra28 <vinjain@redhat.com>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label May 26, 2020
danielhelfand
danielhelfand approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@danielhelfand danielhelfand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2020
@tekton-robot tekton-robot merged commit 028088b into tektoncd:master May 26, 2020
@vinamra28 vinamra28 deleted the vinamra28/prlog-fix branch June 29, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhelfand danielhelfand danielhelfand approved these changes

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

@sthaha sthaha Awaiting requested review from sthaha

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

Assignees

@piyush-garg piyush-garg

@danielhelfand danielhelfand

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
0.10.0 🐅
Development

Successfully merging this pull request may close these issues.

tkn pr logs <pr-name> shows No logs found before showing the logs for a running pipeline run
4 participants
@vinamra28 @tekton-robot @piyush-garg @danielhelfand