-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix --keep with TaskRun and PipelineRun Delete when Using --task or --pipeline Flags #990
Conversation
The following is the coverage report on the affected files.
|
@danielhelfand needs a rebase 😅 |
The following is the coverage report on the affected files.
|
/test pull-tekton-cli-integration-tests-0_10 |
@vdemeester Rebased. If it looks good, would be great to still consider for v0.10.0 if not too late. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm very nice thanks, (i wasn't able to test this directly but the code and tests looks good) |
Closes #965
This pull request makes
--keep
compatible withtkn tr delete --task
andtkn pr delete --pipeline
. With these changes,tkn tr delete --task taskName --keep 2
would filter TaskRuns by a Task name and keep the most recent 2 TaskRuns associated with the TasktaskName
.Deletion confirmation messages have been updated for this case as follows:
This pull request also fixes tests associated with
--keep
with TaskRun, which had no Task test data set up for the test. This resulted in the tests not adequately testing if the correct output was received.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make check
make generated
Release Notes