Use stopAndFail instead of fail with onError 馃
#497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit proposes changing the wording of the `fail` option for `onError` from `fail` to make it more explicitly clear that this option (which is the default behavior when `onError` is not specified) will both cause the Task to fail AND stop execution of any subsequent steps. This change doesn't propose changing any of the described functionality, just the value of the field.
tekton-robot
added
the
size/XS
|
p.s. if anyone can think of better wording than |
bobcatfish
added
the
kind/tep
|
thanks @bobcatfish, sounds good 馃憤 The same pattern can be extended to propose debug functionality, /approve |
tekton-robot
added
the
approved
bobcatfish
added a commit
to bobcatfish/pipeline
that referenced
this pull request
Aug 12, 2021
This commit proposes changes the wording of the `fail` option for `onError` from `fail` to make it more explicitly clear that this option (which is the default behavior when `onError` is not specified) will both cause the Task to fail AND stop execution of any subsequent steps. This change doesn't propose changing any of the described functionality, just the value of the field. Change to the TEP should be approved before this is merged (tektoncd/community#497) and if we go ahead with it we should do a patch release ASAP to minimize user impact - that being said, this change impacts the default value of the field which users are unlikely to specify explicitly - users are much more likely to start using `onError: continue` and for them there would be no impact.
5 tasks
|
/approve |
1 task
vdemeester
approved these changes
Aug 13, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai, sbwsg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
haha good question @vdemeester ! talked it over with some folks and currently leaning toward
But anyway I think either is totally reasonable :D |
|
Thank you everyone 馃檹 |
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Aug 13, 2021
This commit proposes changes the wording of the `fail` option for `onError` from `fail` to make it more explicitly clear that this option (which is the default behavior when `onError` is not specified) will both cause the Task to fail AND stop execution of any subsequent steps. This change doesn't propose changing any of the described functionality, just the value of the field. Change to the TEP should be approved before this is merged (tektoncd/community#497) and if we go ahead with it we should do a patch release ASAP to minimize user impact - that being said, this change impacts the default value of the field which users are unlikely to specify explicitly - users are much more likely to start using `onError: continue` and for them there would be no impact.
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Aug 16, 2021
This commit proposes changes the wording of the `fail` option for `onError` from `fail` to make it more explicitly clear that this option (which is the default behavior when `onError` is not specified) will both cause the Task to fail AND stop execution of any subsequent steps. This change doesn't propose changing any of the described functionality, just the value of the field. Change to the TEP should be approved before this is merged (tektoncd/community#497) and if we go ahead with it we should do a patch release ASAP to minimize user impact - that being said, this change impacts the default value of the field which users are unlikely to specify explicitly - users are much more likely to start using `onError: continue` and for them there would be no impact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit proposes changing the wording of the
failoption foronErrorfromfailto make it more explicitly clear that this option(which is the default behavior when
onErroris not specified) willboth cause the Task to fail AND stop execution of any subsequent steps.
This change doesn't propose changing any of the described functionality,
just the value of the field.
PTAL @pritidesai @vdemeester ( @afrittoli I think you're on holiday right now, given this is such a minor change I'm assuming you will be okay with it but strong apologies if not!! 馃檹 )