Fix TEP Linting #614
Merged
Fix TEP Linting #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the date on TEP-0089 to pass the PipelineRun on open TEPs. The `pull-community-teps-lint` PipelineRun did not run when we merged TEP-0089 in tektoncd#529. It got merged with a linting issue - wrong date - that's causing the same PipelineRun to fail in open TEPs.
tekton-robot
added
the
size/XS
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the date on TEP-0089 to pass the PipelineRun on open TEPs (which is failing and blocking all PRs in this repo).
The
pull-community-teps-lintPipelineRun did not run when we merged TEP-0089 in #529. It got merged with a linting issue - wrong date - that's causing the same PipelineRun to fail in open TEPs. Why it didn't run in that PR is still a mystery but focusing on unblocking PRs for now.Examples: