-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 'all namespaces' option #166
Comments
Backend api will be However one issue here |
Updated description to include example of how this is handled by the kube API server. |
The all namespaces option should be specific to get all CRD routes? |
I favor anything except for the additional routes option where we |
Updates @steveodonovan @AlanGreene ? |
@AlanGreene @steveodonovan the latest PR for this issue has broken the "Import Tekton resources" page. When the "All Namespaces" option is selected, we can't allow the user to create any Tekton resources (because they fail to be created). Right now the "Import Tekton resource" page does not provide the user with any feedback in this failure case. We could solve this problem by displaying an error message such as "Please select a namespace from the left navigation menu." What do you think? (I will also have to update my Create PipelineRun paneling code to address the "all namespaces" option, and @carlos-logro will have to update his Create Secret paneling.) Also, are you going to fix this problem with the "Import Tekton resource" page under your issue here, or should I create a new issue for it? |
The import page should have a namespace dropdown, that was the approach we discussed for this and other panels including the extensions. I missed its absence during reviews, my bad. I've already discussed this with Carlos in relation to the secrets work and changes needed to the APIs to support 'all namespaces'. |
Ok, thanks for the clarification. So the namespaces dropdown in the Side Nav is only for Read operations? Then each Create operation page will need to have its own namespace dropdown? |
Exactly, that was the reason for the creation of the NamespacesDropdown component. |
Current UI only displays resources from a single namespace at a time, controlled by the namespace dropdown in the side nav.
We should add an 'all namespaces' option to the dropdown so that a user can choose to view all resources of a given type (e.g. Pipeline, TaskRun, etc.) defined in the cluster regardless of namespace.
/namespaces/{name}
)Regardless of which option we pursue there are some front end changes that will need to be made:
The text was updated successfully, but these errors were encountered: