Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Secrets and ServiceAccounts functionality #1930

Closed
AlanGreene opened this issue Feb 3, 2021 · 2 comments · Fixed by #1931
Closed

Remove Secrets and ServiceAccounts functionality #1930

AlanGreene opened this issue Feb 3, 2021 · 2 comments · Fixed by #1931
Assignees
@AlanGreene
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/misc Categorizes issue or PR as a miscellaneuous one.

Comments

@AlanGreene
Copy link
Member

AlanGreene commented Feb 3, 2021 •
edited

Request

Remove the Secrets and ServiceAccounts functionality from the Dashboard.

Reasoning

  • Current support is incomplete
    • only supports creating basic-auth secrets with Tekton annotations for git / docker
    • can only patch Secret onto ServiceAccount during Secret create flow
    • no ability to remove Secret from ServiceAccount (apart from automatic removal when deleting a Secret in the UI)
  • requires more permissions than the Dashboard should probably have (e.g. get/list secrets in all namespaces)
  • Dashboard UI provides little benefit over kubectl or other tools for creating / managing secrets
  • supporting the existing functionality contributes to a lot of complexity in both the backend (special handling / sanitisation) and frontend

Proposal

  1. Remove the functionality in the upcoming Dashboard 0.14 release
@AlanGreene AlanGreene added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/wg-discuss Indicates an issue that needs to be discussed during a working group call. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Feb 3, 2021
@AlanGreene AlanGreene self-assigned this Feb 3, 2021
This was referenced Feb 3, 2021
Closed
Closed
@AlanGreene
Copy link
Member Author

Brought this up on the general Tekton working group today asking for feedback. Let's see what response we get in the next week or so.

This was referenced Feb 3, 2021
Merged
Closed
@AlanGreene AlanGreene removed the triage/wg-discuss Indicates an issue that needs to be discussed during a working group call. label Feb 9, 2021
@AlanGreene
Copy link
Member Author

Proceeding with removal for 0.14 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlanGreene AlanGreene

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/misc Categorizes issue or PR as a miscellaneuous one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Secrets and ServiceAccounts pages AlanGreene/dashboard
1 participant
@AlanGreene