Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assess the move to Triggers 0.2 (Dashboard) #918

Closed
a-roberts opened this issue Jan 20, 2020 · 7 comments
Closed

Assess the move to Triggers 0.2 (Dashboard) #918

a-roberts opened this issue Jan 20, 2020 · 7 comments
Assignees

Comments

@a-roberts
Copy link
Member

a-roberts commented Jan 20, 2020

As an end user I expect to be able to use the Tekton Dashboard with Triggers 0.2. When using the webhooks extension there's a fundamental flaw with our architecture too - a user can't create more than eight webhooks or they'll get an admission webhook timeout error (more details at tektoncd/triggers#356)

Related webhooks issue tektoncd/experimental#431

@a-roberts a-roberts changed the title Assess the move to Triggers 0.2 Assess the move to Triggers 0.2 (Dashboard) Jan 20, 2020
@a-roberts a-roberts self-assigned this Jan 20, 2020
@a-roberts
Copy link
Member Author

a-roberts commented Jan 20, 2020

Issues found when installing Triggers 0.2 after having the dashboard and extension and Triggers 0.1 already installed:

No displaying of Trigger resources

Failed to load resource: the server responded with a status of 404 (Not Found)
https://tekton-dashboard-tekton-pipelines.apps.myip/proxy/apis/apiextensions.k8s.io/v1beta1/customresourcedefinitions/eventlisteners.tekton.dev

Actually

proxy/apis/apiextensions.k8s.io/v1beta1/customresourcedefinitions/

seeing this with 0.1 too on OpenShift. #919 created

@a-roberts
Copy link
Member Author

a-roberts commented Jan 20, 2020

Fix for trigger resource displaying on OpenShift #920

I'll look at the rest once I've got an EventListener with webhooks as per tektoncd/experimental#431, there may be other fields in Triggers 0.2 but we won't worry about those just yet unless we're erroring

@a-roberts
Copy link
Member Author

@ncskier and I have been contemplating and testing this, so with an EventListener made with 0.1, and then with Triggers 0.2 installed, everything appears great - including TriggerTemplates and TriggerBindings.

We think there'll be a problem when we have multiple interceptors (in that they won't be picked up from the array, as you can now have multiple) and the same principle applies for bindings (of which there can now be multiple).

@a-roberts
Copy link
Member Author

a-roberts commented Jan 21, 2020

@kimholmes hey Kim, here's the item for assessing the Triggers 0.2 move - so once this is done and someone wants to implement 0.2 support, please work with @kimholmes and co on progressing this item forwards.

We're thinking of doing the move to Triggers 0.2 after we move to Pipelines 0.10.

@ncskier
Copy link
Member

ncskier commented Jan 21, 2020

I think Adam pretty much covered everything we'll need to update; here's a summary so we can view everything all at once (let me know if I missed anything):

TriggerTemplate list & details pages

No change

TriggerBinding list & details pages

No change

EventListener details page

  1. Multiple interceptors
    EventListener triggers can now have multiple interceptors instead of just one. So, we must display this list of interceptors.
  2. Multiple bindings
    EventListener triggers can now have multiple bindings instead of just one. So, we must display this list of bindings.
  3. No more params
    EventListener triggers no longer have params. So, we must no longer display the list of params.

EventListener list page

No change

@kimholmes
Copy link

Thank you @a-roberts and @ncskier

@a-roberts
Copy link
Member Author

Assessments done so I'll make follow-up issue(s) for getting it in, keeping #937 in mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants