Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Repository' and 'Branch' filters to PipelineRuns #47

Closed
mnuttall opened this issue Jun 5, 2019 · 8 comments
Closed

Add 'Repository' and 'Branch' filters to PipelineRuns #47

mnuttall opened this issue Jun 5, 2019 · 8 comments
Labels
design-help-wanted lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. webhooks

Comments

@mnuttall
Copy link
Contributor

mnuttall commented Jun 5, 2019

This issue is part of experimental epic #37 but concerns development changes in dashboard. The webhooks extension needs to be able to filter pipeline runs by repository and branch: it makes sense to surface this capability to dashboard users.

Under Dashboard > PipelineRuns, users should be able to filter the pipeline runs shown by 'git repository' and 'branch'. These can be passed as query params to the /pipelineruns REST API. We should apply labels to pipeline runs so as to be able to filter by these labels when obtaining pipeline runs via the Go client.

@vtereso
Copy link

vtereso commented Jun 19, 2019

IIUC, a pipelineRun is related to a branch/repo through an assumed GitResource (as specified here). I will add labels to runs created through the dashboard should the resource exist.

@vtereso
Copy link

vtereso commented Jun 19, 2019

/assign

@dibbles
Copy link
Member

dibbles commented Jun 24, 2019

I'm not sure this approach would fulfill what we are attempting to achieve, unless I have misunderstood things in the PR (see further notes on PR) : tektoncd/dashboard#279

@vtereso vtereso removed their assignment Jul 8, 2019
@kimholmes
Copy link

Working on this user flow. Would love feedback:

Default state:
TektonFilter1

Hover state:
TektonFilter2

Click state:
TektonFilter3

Typing state. User can press enter or select from the dropdown:
TektonFilter4

Filter added:
TektonFilter5

@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 12, 2020
@tekton-robot tekton-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 12, 2020
@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-help-wanted lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. webhooks
Projects
None yet
Development

No branches or pull requests

5 participants