Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HA and deployment override configuration #1333

Closed
wants to merge 1 commit into from
Closed

Add HA and deployment override configuration #1333

wants to merge 1 commit into from

Conversation

yuzp1996
Copy link
Contributor

@yuzp1996 yuzp1996 commented Feb 19, 2023 •
edited
Loading

Add HA configuration replicas for tektonPipeline.

Add deploymet override configuration for tektonPipeline components for example resource env and args override.

related issue: #1293

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 19, 2023
@tekton-robot
Copy link
Contributor

Hi @yuzp1996. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 19, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vincent-pli after the PR has been reviewed.
You can assign the PR to them by writing /assign @vincent-pli in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 19, 2023
@yuzp1996
Add HA and deployment override configuration
c04f243 
Add HA configuration replicas TektonConfig.

Add deploymet override configuration for TektonConfig, for example
resource env and args override.

Modify the logic of computeDeploymentHash by deleting the logic of ignoring replicas.

Signed-off-by: yuzhipeng <zpyu@alauda.io>
jkandasa
jkandasa reviewed Feb 20, 2023
View reviewed changes
pkg/apis/operator/v1alpha1/tektonconfig_types.go
Env []corev1.EnvVar `json:"env,omitempty"`
// Args represent the args will append to the existing args
// +optional
Args []string `json:"args,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, I prefer to add it under CommonSpec or something similar struct, with all these values and keep it under specific resource(pipeline, dashboard, etc...),
Keeping it away from resource and referring by name, may lead configuration typo issues (naming, etc.,) and may not be user friendly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! I will split args setting to other PR to make sure only resource setting remains here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuzp1996 I meant to move everything under a specific resource (pipeline, dashboard, etc...), including HighAvailability, DeploymentOverride, ContainerOverride

@vdemeester @piyush-garg WDYT?

Copy link
Contributor Author

@yuzp1996 yuzp1996 Mar 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkandasa @vdemeester @piyush-garg Looks like I should start by describing how I will accomplish HA in TEP. I'll keep contributing to this PR when we reach an agreement at TEP.

Do you have any advice now? 😄

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2023
@tekton-robot
Copy link
Contributor

@yuzp1996: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 24, 2023
@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 23, 2023
@jkandasa
Copy link
Member

@yuzp1996 I have added new fields options under each component. now we can modify (limited fields) Deployments, ConfigMaps, and StatefulSets
PR: #1656
please raise a GH ticket if you think something is missing in that PR.
I am closing this PR.
thanks @yuzp1996 !

@jkandasa jkandasa closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkandasa jkandasa jkandasa left review comments

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yuzp1996 @tekton-robot @jkandasa