Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/update e2e tests to support OpenShift environment #1442

Merged
merged 1 commit into from May 12, 2023
Merged

Fix/update e2e tests to support OpenShift environment #1442

merged 1 commit into from May 12, 2023

Conversation

jkandasa
Copy link
Member

@jkandasa jkandasa commented Apr 11, 2023 •
edited by concaf

Changes

  • modified e2e tests and added additional tests in TektonConfigDeployment, TektonHubDeployment
  • modified TektonChainTutorial e2e tests, to support in OpenShift environment
  • modified TektonHub reconciler to address some of issues
  • added ClusterRole, ClusterRoleBinding, ServiceAccount informers into InstallerSet reconciler, without this service account is not created occasionally.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Apr 11, 2023
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 11, 2023
@jkandasa
Copy link
Member Author

jkandasa commented Apr 11, 2023 •
edited

cc @concaf @PuneetPunamiya @vdemeester @piyush-garg

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonhub_validation.go 95.0% 94.1% -0.9

@jkandasa jkandasa marked this pull request as draft April 11, 2023 11:30
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2023
@jkandasa jkandasa force-pushed the fix_e2e_openshift branch 2 times, most recently from b48488e to 04c0387 Compare April 11, 2023 13:27
@jkandasa jkandasa marked this pull request as ready for review April 11, 2023 13:29
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2023
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonhub_validation.go 95.0% 94.1% -0.9

@jkandasa jkandasa mentioned this pull request Apr 11, 2023
Merged
4 tasks
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonhub_validation.go 95.0% 94.1% -0.9

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonhub_validation.go 95.0% 94.1% -0.9

vdemeester
vdemeester reviewed Apr 11, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonhub_validation.go 95.0% 94.1% -0.9

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2023
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2023
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonhub_validation.go 95.0% 94.1% -0.9

@jkandasa
Copy link
Member Author

/retest

@jkandasa
fix tektonConfig, chain tutorial and hub e2e test issues in OpenShift…
7cb2441 
… environment

Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com>
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonhub_validation.go 95.0% 94.1% -0.9

@vdemeester
Copy link
Member

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2023
@piyush-garg
Copy link
Contributor

i am merging this PR for now

we will keep adding and refactoring in tests as we encounter anything.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2023
@tekton-robot tekton-robot merged commit a9aac2d into tektoncd:main May 12, 2023
8 checks passed
@jkandasa jkandasa deleted the fix_e2e_openshift branch May 15, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester left review comments

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

Assignees

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jkandasa @tekton-robot @vdemeester @piyush-garg