Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding verification-mode field back to pipelines spec to unblock the upgrade failure #1498

Merged
merged 1 commit into from
May 23, 2023

Conversation

jkandasa
Copy link
Member

Changes

verification-mode removed on part of #1481, but it was there in previous releases, which leads the following issue in webhook,

{"level":"info","logger":"tekton-operator-webhook","caller":"webhook/admission.go:151","msg":"remote admission controller audit annotations=map[string]string(nil)","commit":"8e8c163","knative.dev/kind":"operator.tekton.dev/v1alpha1, Kind=TektonConfig","knative.dev/namespace":"","knative.dev/name":"config","knative.dev/operation":"UPDATE","knative.dev/resource":"operator.tekton.dev/v1alpha1, Resource=tektonconfigs","knative.dev/subresource":"","knative.dev/userinfo":"system:serviceaccount:openshift-operators:openshift-pipelines-operator","admissionreview/uid":"958be8bd-9d63-4b95-aa7d-9285684ff86c","admissionreview/allowed":false,"admissionreview/result":"&Status{ListMeta:ListMeta{SelfLink:,ResourceVersion:,Continue:,RemainingItemCount:nil,},Status:Failure,Message:mutation failed: cannot decode incoming old object: json: unknown field \"verification-mode\",Reason:BadRequest,Details:nil,Code:400,}"}

To unblock the upgrade, I am adding back. I have created an issue to remove verification-mode field => #1497

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label May 18, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 18, 2023
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

@khrm: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jkandasa
Copy link
Member Author

/cc @concaf

@tekton-robot tekton-robot requested a review from concaf May 18, 2023 14:18
@jkandasa
Copy link
Member Author

/cc @PuneetPunamiya

@tekton-robot
Copy link
Contributor

@jkandasa: GitHub didn't allow me to request PR reviews from the following users: PuneetPunamiya.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @PuneetPunamiya

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@piyush-garg
Copy link
Contributor

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2023
…upgrade failure

Signed-off-by: Jeeva Kandasamy <jkandasa@redhat.com>
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2023
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonpipeline_defaults.go 90.6% 90.7% 0.2

@PuneetPunamiya
Copy link
Member

LGTM

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm, piyush-garg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [piyush-garg,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@piyush-garg
Copy link
Contributor

/lgtm

@piyush-garg
Copy link
Contributor

/cherry-pick v0.67.0

@tekton-robot
Copy link
Contributor

@piyush-garg: once the present PR merges, I will cherry-pick it on top of v0.67.0 in a new PR and assign it to you.

In response to this:

/cherry-pick v0.67.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot merged commit 1f3f8eb into tektoncd:main May 23, 2023
2 checks passed
@tekton-robot
Copy link
Contributor

@piyush-garg: cannot checkout v0.67.0: error checking out v0.67.0: exit status 1. output: error: pathspec 'v0.67.0' did not match any file(s) known to git

In response to this:

/cherry-pick v0.67.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jkandasa jkandasa deleted the fix_unknow_filed branch May 23, 2023 08:02
@jkandasa
Copy link
Member Author

/cherry-pick release-v0.67.x

@tekton-robot
Copy link
Contributor

@jkandasa: new pull request created: #1502

In response to this:

/cherry-pick release-v0.67.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants