Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Google Creds for Results #1652

Merged
merged 1 commit into from Sep 8, 2023
Merged

Add Google Creds for Results #1652

merged 1 commit into from Sep 8, 2023

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Aug 23, 2023 •
edited

Enables passing of GCS creds using k8s secret.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Pass Google creds for GCS to Results using the following properties:
gcs_creds_secret_name
gcs_creds_secret_key

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 23, 2023
@khrm
Copy link
Contributor Author

khrm commented Aug 23, 2023

/kind feature

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 23, 2023
@khrm khrm force-pushed the gcreds branch 3 times, most recently from 9f111f8 to 9631792 Compare August 23, 2023 09:09
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektonresult/transform.go 70.9% 76.1% 5.2

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektonresult/transform.go 70.9% 76.1% 5.2

@khrm khrm changed the title WIP: Add Google Creds for Results Add Google Creds for Results Aug 23, 2023
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2023
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektonresult/transform.go 70.9% 76.1% 5.2

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektonresult/transform.go 70.9% 76.7% 5.8

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektonresult/transform.go 70.9% 76.7% 5.8

@tektoncd tektoncd deleted a comment from tekton-robot Sep 4, 2023
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektonresult/transform.go 70.9% 76.7% 5.8

@khrm khrm force-pushed the gcreds branch 2 times, most recently from c445c9d to 29ad272 Compare September 4, 2023 12:14
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektonresult/transform.go 70.9% 76.7% 5.8

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektonresult/transform.go 70.9% 76.7% 5.8

khrm
khrm commented Sep 7, 2023
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PuneetPunamiya This is ready for review. I rebased it with latest main.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektonresult/transform.go 70.9% 76.7% 5.8

@piyush-garg
Copy link
Contributor

minor comments, rest lgtm

@khrm khrm force-pushed the gcreds branch 2 times, most recently from 7cb1425 to 8ea509f Compare September 8, 2023 06:48
@khrm
Add Google Creds for Results
e0e4c4c 
Enables passing of GCS creds using k8s secret.
khrm
khrm commented Sep 8, 2023
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piyush-garg @jkandasa I fixed those minor comments.Please re-review.

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektonresult/transform.go 70.9% 76.7% 5.8

@piyush-garg
Copy link
Contributor

lgtm
cc @jkandasa

jkandasa
jkandasa reviewed Sep 8, 2023
View reviewed changes
Copy link
Member

@jkandasa jkandasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2023
@tekton-robot tekton-robot merged commit 18f3f23 into tektoncd:main Sep 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkandasa jkandasa jkandasa left review comments

@piyush-garg piyush-garg piyush-garg left review comments

@vdemeester vdemeester vdemeester approved these changes

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

Assignees

@jkandasa jkandasa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@khrm @tekton-robot @piyush-garg @vdemeester @jkandasa