Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Results extension manifest to TektonAddon #1728

Closed
wants to merge 1 commit into from
Closed

Add Results extension manifest to TektonAddon #1728

wants to merge 1 commit into from

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Sep 25, 2023 •
edited

Changes

Fixes #1729

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 25, 2023
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 25, 2023
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/results.go Do not exist 0.0%

@khrm
Copy link
Contributor Author

khrm commented Sep 25, 2023

/cherry-pick release-v0.68.0

@tekton-robot
Copy link
Contributor

@khrm: once the present PR merges, I will cherry-pick it on top of release-v0.68.0 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.68.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@khrm
Copy link
Contributor Author

khrm commented Sep 25, 2023

/cherry-pick release-v0.68.x

@tekton-robot
Copy link
Contributor

@khrm: once the present PR merges, I will cherry-pick it on top of release-v0.68.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.68.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

khrm
khrm commented Sep 25, 2023
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @jkandasa @vdemeester

@vdemeester
Copy link
Member

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2023
@concaf
Copy link
Contributor

concaf commented Feb 7, 2024

needs to be closed

khrm
khrm commented Feb 7, 2024
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/close

@PuneetPunamiya
Copy link
Member

/close

@khrm khrm closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

Assignees

@vdemeester vdemeester

@jkandasa jkandasa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TektonResult Route isn't accessible to OpenShift to system:authenticated user
6 participants
@khrm @tekton-robot @vdemeester @concaf @PuneetPunamiya @jkandasa