Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e tests for triggers and dashboard #174

Merged
merged 3 commits into from Nov 26, 2020
Merged

Add e2e tests for triggers and dashboard #174

merged 3 commits into from Nov 26, 2020

Conversation

nikhil-thomas
Copy link
Member

@nikhil-thomas nikhil-thomas commented Nov 24, 2020 •
edited

Fix CheckDeployment stage in pkg/reconciler/common: all reconcilers
were flaky as events were no requeued on deployment unavailable.

Add create, restore-deployments and delete e2e tests for TektonTriggers and TektonDashboard.

comment aggregationRule resource: ClusterRole, name: tekton-dashboard-extensions` to dashboard e2e tests and reconciler run without providing cluster admin privileges to operator sa. (#131)

Comment

Refactor TektonPipelines e2e tests

Signed-off-by: Nikhil Thomas nikthoma@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 24, 2020
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 24, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/deployments.go 90.0% 94.4% 4.4

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/deployments.go 90.0% 94.4% 4.4

@nikhil-thomas nikhil-thomas changed the title Add e2e tests for triggers [WIP] Add e2e tests for triggers Nov 24, 2020
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2020
@nikhil-thomas nikhil-thomas mentioned this pull request Nov 24, 2020
Closed
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/deployments.go 90.0% 94.4% 4.4

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/deployments.go 90.0% 94.4% 4.4

@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 24, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/deployments.go 90.0% 94.4% 4.4

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/deployments.go 90.0% 94.4% 4.4

@nikhil-thomas nikhil-thomas changed the title [WIP] Add e2e tests for triggers Add e2e tests for triggers and dashboard Nov 25, 2020
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/deployments.go 90.0% 94.4% 4.4

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/deployments.go 90.0% 94.4% 4.4

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2020
@nikhil-thomas
Add e2e tests for triggers
a8f5c1e 
Fix `CheckDeployment` stage in `pkg/reconciler/common`: all reconcilers
were flaky as events were no requeued on deployment unavailable.

Add create, restore-deployment, and delete e2e tests for triggers

Refactor pipelines e2e tests

Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
@nikhil-thomas
Add e2e tests for TektonDashboard Reconciler
d188e8f 
Add create, restore-deployments, delete e2e tests

Fix flakiness in TektonPipline e2e tests by explicity adding a
delete TektonPipelineCR mechanism in triggers, and dashboard e2e tests.

Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
@nikhil-thomas
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2020
@nikhil-thomas
Update Makefile and test scripts
5ec44f9 
Remove obsolete make target (based on operator-sdk)

Modify `test/e2e-common.sh` to make sure that we get `No resource found`
(or resource deletion), instead of `CRD not defined error`

Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
@nikhil-thomas
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/deployments.go 90.0% 94.4% 4.4

@vincent-pli
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2020
@tekton-robot tekton-robot merged commit fd308e6 into tektoncd:main Nov 26, 2020
@06kellyjac 06kellyjac mentioned this pull request Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@vincent-pli vincent-pli Awaiting requested review from vincent-pli

Assignees

@vincent-pli vincent-pli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nikhil-thomas @tekton-robot @vincent-pli @vdemeester