Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds recently added pipelinerun and builder artifacts to chains spec #1999

Merged
merged 1 commit into from Feb 15, 2024
Merged

Adds recently added pipelinerun and builder artifacts to chains spec #1999

merged 1 commit into from Feb 15, 2024

Conversation

PuneetPunamiya
Copy link
Member

@PuneetPunamiya PuneetPunamiya commented Feb 15, 2024 •
edited by jkandasa

Following are the artifacts added

  • artifacts.pipelinerun.enable-deep-inspection
  • builddefinition.buildtype

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Adds support for `artifacts.pipelinerun.enable-deep-inspection` and `builddefinition.buildtype` to Chains spec

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 15, 2024
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 15, 2024
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 15, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonchain_validation.go 70.6% 71.7% 1.1

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@piyush-garg
Copy link
Contributor

/cherry-pick main

@tekton-robot
Copy link
Contributor

@piyush-garg: once the present PR merges, I will cherry-pick it on top of main in a new PR and assign it to you.

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PuneetPunamiya
Adds recently added pipelinrun and builder artifacts to chains spec
2bbe12e 
Following are the artifacts added

* artifacts.pipelinerun.enable-deep-inspection
* builddefinition.buildtype

Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
@jkandasa jkandasa added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 15, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonchain_validation.go 70.6% 71.7% 1.1

@PuneetPunamiya PuneetPunamiya changed the title Adds recently added pipelinrun and builder artifacts to chains spec Adds recently added pipelinerun and builder artifacts to chains spec Feb 15, 2024
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@tekton-robot tekton-robot merged commit e907b04 into tektoncd:release-v0.70.x Feb 15, 2024
6 checks passed
@tekton-robot
Copy link
Contributor

@piyush-garg: new pull request created: #2000

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkandasa jkandasa jkandasa approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@savitaashture savitaashture Awaiting requested review from savitaashture

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PuneetPunamiya @tekton-robot @piyush-garg @jkandasa