Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] support startingDeadlineSeconds configuration in pruner cron jobs #2059

Merged

Conversation

jkandasa
Copy link
Member

@jkandasa jkandasa commented Mar 21, 2024

Changes

  • Fixes: SRVKP-4277 - Inclusion of configuration parameter "startingDeadlineSeconds" in TektonConfig
  • Added support to startingDeadlineSeconds in pruner cron jobs

Example in TektonConfig CR:

pruner:
  schedule: "0 8 * * *"
  startingDeadlineSeconds: 100 # optional
  resources:
    - taskrun
    - pipelinerun
  keep: 3

NOTE: under pruner config all the existing fields are in snake_case. Cron Job has spec.startingDeadlineSeconds as camelCase, to have the consistency across, using startingDeadlineSeconds as camelCase.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

`startingDeadlineSeconds` configuration support added to pruner cron jobs via TektonConfig CR

Signed-off-by: Jeeva Kandasamy <jkandasa@redhat.com>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 21, 2024
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 21, 2024
@jkandasa jkandasa changed the title [main] support startingDeadlineSeconds in pruner cron jobs [main] support startingDeadlineSeconds configuration in pruner cron jobs Mar 21, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/prune.go 89.4% 89.7% 0.3

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2024
@tekton-robot tekton-robot merged commit eb9e5f2 into tektoncd:main Mar 21, 2024
8 checks passed
@jkandasa jkandasa deleted the support_starting_deadline_seconds branch March 21, 2024 06:31
@jkandasa jkandasa mentioned this pull request Mar 21, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants