Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] apply nodeSelector, tolerations, and priorityClassName into pipelines-console-plugin pod #2109

Merged

Conversation

jkandasa
Copy link
Member

Changes

  • applies nodeSelector, tolerations, and priorityClassName from tektonConfig.config to pipelines-console-plugin pod
  • Fixes: SRVKP-4391 - pipelines-console-plugin Pod doesn't move to infra nodes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

…-console-plugin pod

Signed-off-by: Jeeva Kandasamy <jkandasa@redhat.com>
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Apr 11, 2024
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 11, 2024
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
@jkandasa
Copy link
Member Author

/cherry-pick release-v0.70.x

@tekton-robot
Copy link
Contributor

@jkandasa: once the present PR merges, I will cherry-pick it on top of release-v0.70.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.70.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rupalibehera
Copy link
Member

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rupalibehera, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
@tekton-robot tekton-robot merged commit 43d0d88 into tektoncd:main Apr 11, 2024
8 checks passed
@tekton-robot
Copy link
Contributor

@jkandasa: new pull request created: #2110

In response to this:

/cherry-pick release-v0.70.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jkandasa jkandasa deleted the apply_tekton_config_to_console_plugin branch April 11, 2024 13:08
@jkandasa jkandasa added the kind/bug Categorizes issue or PR as related to a bug. label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants