Put back the namespace to reconcile list if a resource cant be created for…

[jkhelil]

… this namespace

Changes

Put back the namespace to the reconcile list if a resource creation is failing for this namespace, so we continue reconciling even if an error happens when creating a resource one namespace.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Run make test lint before submitting a PR
• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

Put back the namespace to the reconcile list if a resource creation is failing for this namespace, so we continue reconciling even if an error happens when creating a resource one namespace.

[tekton-robot]

Hi @jkhelil. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jkhelil]

@jkandasa @piyush-garg can i have a first rview here please ?
thank you

[jkandasa]

/ok-to-test

[jkandasa]

@jkhelil When we return from the loop on error on a specific namespace issue, we fail to reconcile further namespaces until we fix the error on the specific namespace. So IMHO, we can continue to proceed with further namespaces, even though we see error on a namespace.

[jkhelil]

hey @jkandasa thats why we continue juste after the check. here we return from AddNsToReconcileOnError wich is removing the label on the namespace on etcd. so if something is failing there, we dont continue otherwise the namespace will be considered as reconciled without having the prerequisite resources.

[jkandasa]

we return from AddNsToReconcileOnError wich is removing the label on the namespace on etcd. so if something is failing there, we dont continue

@jkhelil I meant this

[piyush-garg]

I did not get this logic, we are not adding the label, untill we are reaching the end of this function, which means everything is created.

I think what we need is more checks whether the namespace needs to be reonciled

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/openshift/tektonconfig/rbac.go	0.0%	2.9%	2.9

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/openshift/tektonconfig/rbac.go	0.0%	2.9%	2.9

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jkandasa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment