[OpenShift] Optimize rbac creation in TektonConfig extention #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 13, 2021 18:54
This adds a label to namespace after creating rbac resources so that on further reconcilation, reconciler won't loop on it and ignore them. Only new namespaces would be looped for rbac resource creation. Also adds a filter to namespace events to queue in TektonConfig only if namespace doesn't match the regex. Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
After installation, pod comes in running state soon but TektonConfig creation takes sometime, which fails the test. Adding a sleep for a 30 seconds, this can be replaced with probes and we should check ready status of pod. Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhil-thomas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a label to namespace after creating rbac resources so
that on further reconcilation, reconciler won't loop on it and ignore
them. Only new namespaces would be looped for rbac resource creation.
Also adds a filter to namespace events to queue in TektonConfig only
if namespace doesn't match the regex.
Signed-off-by: Shivam Mukhade smukhade@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes